Skip to content

Conversation

@yminqi
Copy link
Contributor

@yminqi yminqi commented Oct 12, 2020

Regular hidden class skipping warning in -Xshare:dump is at info log level, it is noise for a normal operation. Changed to debug level, along the change, three test cases in dynamic dumping changed to debug log level to have original message output.

Tests: tier1-5 in progress. Passed all local runtime/cds


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254599: CDS dump should not warn about hidden classes

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/614/head:pull/614
$ git checkout pull/614

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2020

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 12, 2020

⚠️ @yminqi This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 12, 2020
@openjdk
Copy link

openjdk bot commented Oct 12, 2020

@yminqi The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 12, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 12, 2020

@yminqi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254599: CDS dump should not warn about hidden classes

Reviewed-by: redestad, lfoltan, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b464213: 8252407: Build failure with gcc-8+ and asan
  • 2a4328b: 8254610: Problem list test compiler/debug/TestStressCM.java
  • bff586f: 8254269: simplify Node::disconnect_inputs
  • d7128e7: 8254090: Collectors.toUnmodifiableList exposes shared secret

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 12, 2020
Copy link
Member

@lfoltan lfoltan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Yumin!

@yminqi
Copy link
Contributor Author

yminqi commented Oct 12, 2020

Thanks Claes and Lois for the review!

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yminqi
Copy link
Contributor Author

yminqi commented Oct 13, 2020

/integrate

@openjdk openjdk bot closed this Oct 13, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2020
@openjdk
Copy link

openjdk bot commented Oct 13, 2020

@yminqi Since your change was applied there have been 4 commits pushed to the master branch:

  • b464213: 8252407: Build failure with gcc-8+ and asan
  • 2a4328b: 8254610: Problem list test compiler/debug/TestStressCM.java
  • bff586f: 8254269: simplify Node::disconnect_inputs
  • d7128e7: 8254090: Collectors.toUnmodifiableList exposes shared secret

Your commit was automatically rebased without conflicts.

Pushed as commit e49232a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yminqi yminqi deleted the jdk-8254599 branch October 13, 2020 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants