Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275766: (tz) Update Timezone Data to 2021e #6144

Closed
wants to merge 1 commit into from

Conversation

satoyoshiki
Copy link

@satoyoshiki satoyoshiki commented Oct 28, 2021

Please review the integration of tzdata2021e (including tzdata2021d) to the JDK.
The fix has passed all relevant JTREG regression tests and JCK tests.

8275754: (tz) Update Timezone Data to 2021d
8275849: TestZoneInfo310.java fails with tzdata2021e


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6144/head:pull/6144
$ git checkout pull/6144

Update a local copy of the PR:
$ git checkout pull/6144
$ git pull https://git.openjdk.java.net/jdk pull/6144/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6144

View PR using the GUI difftool:
$ git pr show -t 6144

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6144.diff

8275766: (tz) Update Timezone Data to 2021e
8275849: TestZoneInfo310.java fails with tzdata2021e
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2021

👋 Welcome back ysatowse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2021

@satoyoshiki The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Oct 28, 2021
@satoyoshiki satoyoshiki changed the title 8275754: (tz) Update Timezone Data to 2021d 8275766: (tz) Update Timezone Data to 2021e Oct 28, 2021
@satoyoshiki
Copy link
Author

satoyoshiki commented Oct 28, 2021

/issue add JDK-8275766 JDK-8275754 JDK-8275849

@openjdk
Copy link

openjdk bot commented Oct 28, 2021

@satoyoshiki This issue is referenced in the PR title - it will now be updated.

Adding additional issue to issue list: 8275754: (tz) Update Timezone Data to 2021d.

Adding additional issue to issue list: 8275849: TestZoneInfo310.java fails with tzdata2021e.

@satoyoshiki
Copy link
Author

satoyoshiki commented Oct 28, 2021

/reviewer credit @naotoj @coffeys

@openjdk
Copy link

openjdk bot commented Oct 28, 2021

@satoyoshiki
Reviewer naoto successfully credited.

Reviewer coffeys successfully credited.

naotoj
naotoj approved these changes Oct 28, 2021
@openjdk
Copy link

openjdk bot commented Oct 28, 2021

@satoyoshiki This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275766: (tz) Update Timezone Data to 2021e
8275849: TestZoneInfo310.java fails with tzdata2021e

Reviewed-by: naoto, iris, erikj, coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 253 new commits pushed to the master branch:

  • 8630f55: 8275406: Add copy-to-clipboard feature to snippet UI
  • 9971a2c: 8275735: [linux] Remove deprecated Metrics api (kernel memory limit)
  • b7a06be: 8252990: Intrinsify Unsafe.storeStoreFence
  • 92be9d8: 8276236: Table headers missing in Formatter api docs
  • 9bf3165: 8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc
  • 0488ebd: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • acceffc: 8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time
  • 2eafa03: 8276234: Trivially clean up locale-related code
  • 47e7a42: 8262945: [macos] Regression Manual Test for Key Events Fails
  • 99b7b95: 8276205: Shenandoah: CodeCache_lock should always be held for initializing code cache iteration
  • ... and 243 more: https://git.openjdk.java.net/jdk/compare/b1b83500a9c3a74bf39894e49eefd031d208b9b9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@naotoj, @irisclark, @erikj79, @coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2021
@satoyoshiki
Copy link
Author

satoyoshiki commented Oct 29, 2021

/issue remove JDK-8275754

@openjdk
Copy link

openjdk bot commented Oct 29, 2021

@satoyoshiki
Removing additional issue from issue list: 8275754.

@satoyoshiki satoyoshiki marked this pull request as ready for review Oct 29, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2021

Webrevs

@satoyoshiki
Copy link
Author

satoyoshiki commented Nov 2, 2021

@coffeys please complete your review on this PR.

@coffeys
Copy link
Contributor

coffeys commented Nov 2, 2021

I think you've enough Reviewers already but yes, this looks fine.

coffeys
coffeys approved these changes Nov 2, 2021
@satoyoshiki
Copy link
Author

satoyoshiki commented Nov 2, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@satoyoshiki
Your change (at version 83252d0) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Nov 2, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 2, 2021

Going to push as commit 5b4e398.
Since your change was applied there have been 253 commits pushed to the master branch:

  • 8630f55: 8275406: Add copy-to-clipboard feature to snippet UI
  • 9971a2c: 8275735: [linux] Remove deprecated Metrics api (kernel memory limit)
  • b7a06be: 8252990: Intrinsify Unsafe.storeStoreFence
  • 92be9d8: 8276236: Table headers missing in Formatter api docs
  • 9bf3165: 8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc
  • 0488ebd: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • acceffc: 8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time
  • 2eafa03: 8276234: Trivially clean up locale-related code
  • 47e7a42: 8262945: [macos] Regression Manual Test for Key Events Fails
  • 99b7b95: 8276205: Shenandoah: CodeCache_lock should always be held for initializing code cache iteration
  • ... and 243 more: https://git.openjdk.java.net/jdk/compare/b1b83500a9c3a74bf39894e49eefd031d208b9b9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@coffeys @satoyoshiki Pushed as commit 5b4e398.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
5 participants