Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276067: ZGC: Remove unused function alloc_high_address_at_most() #6146

Closed

Conversation

pliden
Copy link
Contributor

@pliden pliden commented Oct 28, 2021

The function ZMemoryManager::alloc_high_address_at_most() is unused and can be removed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276067: ZGC: Remove unused function alloc_high_address_at_most()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6146/head:pull/6146
$ git checkout pull/6146

Update a local copy of the PR:
$ git checkout pull/6146
$ git pull https://git.openjdk.java.net/jdk pull/6146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6146

View PR using the GUI difftool:
$ git pr show -t 6146

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6146.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 28, 2021

👋 Welcome back pliden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@pliden The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Oct 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 28, 2021

Webrevs

fisk
fisk approved these changes Oct 28, 2021
Copy link
Contributor

@fisk fisk left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@pliden This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276067: ZGC: Remove unused function alloc_high_address_at_most()

Reviewed-by: eosterlund, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 593401f: 8276042: Remove unused local variables in java.naming
  • a2f2d8f: 8276057: Update JMH devkit to 1.33

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 28, 2021
@pliden
Copy link
Contributor Author

@pliden pliden commented Oct 28, 2021

Thanks for reviewing!

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

Going to push as commit d88b89f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 593401f: 8276042: Remove unused local variables in java.naming
  • a2f2d8f: 8276057: Update JMH devkit to 1.33

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@pliden Pushed as commit d88b89f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pliden pliden deleted the 8276067_zgc_remove_unused_function branch Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants