Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8275440: Remove VirtualSpaceList::is_full() #6147

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Oct 28, 2021

This function is only used from a single gtest. Ioi remarked that it is not threadsafe. The context in which it is used is not multithreaded, but nevertheless I opted to remove the function and modified the test to make the condition somewhat more generic.

This trades a slight decrease in complexity with a very minor decrease in test precision, but that is fine.

Test:

  • manual gtests
  • GHAs
  • ran the metaspace jtreg gtests, which execute gtests with various metaspace modes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6147/head:pull/6147
$ git checkout pull/6147

Update a local copy of the PR:
$ git checkout pull/6147
$ git pull https://git.openjdk.java.net/jdk pull/6147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6147

View PR using the GUI difftool:
$ git pr show -t 6147

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6147.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 28, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@tstuefe tstuefe force-pushed the JDK-8275440-metaspace-remove-unused-virtualspacelist-is-full branch from 2efcb79 to db4f0b6 Compare Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Oct 28, 2021
@tstuefe tstuefe marked this pull request as ready for review Oct 28, 2021
@openjdk openjdk bot added the rfr label Oct 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 28, 2021

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Looks good, also looks trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275440: Remove VirtualSpaceList::is_full()

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 309acbf: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • abe52ae: 8275518: accessibility issue in Inet6Address docs
  • 85d8cd8: 8276100: Remove G1SegmentedArray constructor name parameter
  • a343fa8: 8275865: Print deoptimization statistics in product builds
  • bec977c: 8275917: Some locks shouldn't allow_vm_block
  • 7c996d5: 8269401: Merge "Exceptions" and "Errors" into "Exception Classes"
  • d88b89f: 8276067: ZGC: Remove unused function alloc_high_address_at_most()
  • 593401f: 8276042: Remove unused local variables in java.naming
  • a2f2d8f: 8276057: Update JMH devkit to 1.33
  • 1750a6e: 8276055: ZGC: Defragment address space

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 28, 2021
@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Oct 29, 2021

Looks good, also looks trivial.

Thanks Coleen. You are right, it is trivial, no need for another review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2021

Going to push as commit c9e65f8.
Since your change was applied there have been 19 commits pushed to the master branch:

  • de93b1d: 8257722: Improve "keytool -printcert -jarfile" output
  • 21da218: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
  • 48f3fca: 8275308: Add valueOf(Runtime.Version) factory to SourceVersion
  • c6339cb: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle
  • 5a768f7: 8276054: JMH benchmarks for Fences
  • 6d8fa8f: 8255286: Implement ParametersTypeData::print_data_on fully
  • 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
  • cb989cf: 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks
  • c92f230: 8276110: Problemlist javax/swing/JMenu/4515762/bug4515762.java for macos12
  • 309acbf: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/d9b0138d7d02ceddc5d9c73908177f0b0d2e7c54...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2021

@tstuefe Pushed as commit c9e65f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe tstuefe deleted the JDK-8275440-metaspace-remove-unused-virtualspacelist-is-full branch Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
2 participants