New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8254611: x86_32: Call to IRT::at_unwind clobbers rthread after JDK-8253180 #615
8254611: x86_32: Call to IRT::at_unwind clobbers rthread after JDK-8253180 #615
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Looks good Aleksey - thanks for fixing. Obviously another solution is to not perform the call on 32 bit x86, as the stack watermark barriers are not supported yet there. But perhaps if someone wants to have a stab at that, it could be good to do roughly the same thing now. With that said - ship it!
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@shipilev Since your change was applied there have been 12 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 90de289. |
There are massive x86_32 tier1 failures, bisection points to JDK-8253180. I think I know why this happens: in
InterpreterMacroAssembler::remove_activation
, there is a new call_VM toInterpreterRuntime::at_unwind
, which broke therthread
(rcx
) that x86_32 needs later. x86_64 is not affected, because it carries it inr15_thread
.Attention @fisk.
Additional testing:
Progress
Testing
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/615/head:pull/615
$ git checkout pull/615