New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276102: JDK-8245095 integration reverted JDK-8247980 #6153
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
That was definitely not intentional, thanks for spotting @shipilev! |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 67 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
All right, thanks for reviews. /integrate |
Going to push as commit 15fd8a3.
Your commit was automatically rebased without conflicts. |
See the integration commit for JDK-8245095. It reintroduced
java/util/stream
inexclusiveAccess.dirs
, which effectively reverts JDK-8247980. I noticed this because jdk:tier1 became slow again.@FrauBoes, that was not intentional, right?
The solution is to drop
java/util/stream
again.Additional testing:
jdk:tier1
tests are fast againProgress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6153/head:pull/6153
$ git checkout pull/6153
Update a local copy of the PR:
$ git checkout pull/6153
$ git pull https://git.openjdk.java.net/jdk pull/6153/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6153
View PR using the GUI difftool:
$ git pr show -t 6153
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6153.diff