Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276100: Remove G1SegmentedArray constructor name parameter #6154

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Oct 28, 2021

Hi all,

can I have reviews for this trivial(?) change to remove an unused parameter to the G1SegmentedArray constructor?

Testing: local compilation

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276100: Remove G1SegmentedArray constructor name parameter

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6154/head:pull/6154
$ git checkout pull/6154

Update a local copy of the PR:
$ git checkout pull/6154
$ git pull https://git.openjdk.java.net/jdk pull/6154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6154

View PR using the GUI difftool:
$ git pr show -t 6154

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6154.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 28, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Oct 28, 2021
@tschatzl tschatzl force-pushed the submit/8276100-remove-name-parameter branch from cf78ca6 to 63754b1 Compare Oct 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 28, 2021

Webrevs

Copy link
Member

@albertnetymk albertnetymk left a comment

LGTM and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276100: Remove G1SegmentedArray constructor name parameter

Reviewed-by: ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bec977c: 8275917: Some locks shouldn't allow_vm_block

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 28, 2021
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Oct 28, 2021

Thanks for your review @albertnetymk

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

Going to push as commit 85d8cd8.
Since your change was applied there have been 2 commits pushed to the master branch:

  • a343fa8: 8275865: Print deoptimization statistics in product builds
  • bec977c: 8275917: Some locks shouldn't allow_vm_block

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@tschatzl Pushed as commit 85d8cd8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8276100-remove-name-parameter branch Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
2 participants