-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8275735: [linux] Remove deprecated Metrics api (kernel memory limit) #6156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
@jerboaa The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
hseigel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Thanks for doing this.
Harold
|
@jerboaa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review! |
|
/integrate |
|
Going to push as commit 9971a2c.
Your commit was automatically rebased without conflicts. |
Please review this change to remove some API which no longer works as expected as recent OCI runtimes start to drop support for
--kernel-memoryswitch. See the bug for references. This part of the API is not present in hotspot code.Testing: Container tests (cgroup v1) on Linux x86_64 (all pass)
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6156/head:pull/6156$ git checkout pull/6156Update a local copy of the PR:
$ git checkout pull/6156$ git pull https://git.openjdk.java.net/jdk pull/6156/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6156View PR using the GUI difftool:
$ git pr show -t 6156Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6156.diff