Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275735: [linux] Remove deprecated Metrics api (kernel memory limit) #6156

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Oct 28, 2021

Please review this change to remove some API which no longer works as expected as recent OCI runtimes start to drop support for --kernel-memory switch. See the bug for references. This part of the API is not present in hotspot code.

Testing: Container tests (cgroup v1) on Linux x86_64 (all pass)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275735: [linux] Remove deprecated Metrics api (kernel memory limit)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6156/head:pull/6156
$ git checkout pull/6156

Update a local copy of the PR:
$ git checkout pull/6156
$ git pull https://git.openjdk.java.net/jdk pull/6156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6156

View PR using the GUI difftool:
$ git pr show -t 6156

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6156.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 28, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@jerboaa The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability hotspot-runtime core-libs labels Oct 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 28, 2021

Webrevs

Copy link
Member

@hseigel hseigel left a comment

The changes look good. Thanks for doing this.
Harold

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275735: [linux] Remove deprecated Metrics api (kernel memory limit)

Reviewed-by: hseigel, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
  • cb989cf: 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks
  • c92f230: 8276110: Problemlist javax/swing/JMenu/4515762/bug4515762.java for macos12
  • 309acbf: 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem
  • abe52ae: 8275518: accessibility issue in Inet6Address docs
  • 85d8cd8: 8276100: Remove G1SegmentedArray constructor name parameter
  • a343fa8: 8275865: Print deoptimization statistics in product builds
  • bec977c: 8275917: Some locks shouldn't allow_vm_block
  • 7c996d5: 8269401: Merge "Exceptions" and "Errors" into "Exception Classes"
  • d88b89f: 8276067: ZGC: Remove unused function alloc_high_address_at_most()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 28, 2021
@jerboaa
Copy link
Contributor Author

@jerboaa jerboaa commented Oct 28, 2021

The changes look good. Thanks for doing this. Harold

Thanks for the review!

@jerboaa
Copy link
Contributor Author

@jerboaa jerboaa commented Nov 2, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2021

Going to push as commit 9971a2c.
Since your change was applied there have been 53 commits pushed to the master branch:

  • b7a06be: 8252990: Intrinsify Unsafe.storeStoreFence
  • 92be9d8: 8276236: Table headers missing in Formatter api docs
  • 9bf3165: 8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc
  • 0488ebd: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • acceffc: 8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time
  • 2eafa03: 8276234: Trivially clean up locale-related code
  • 47e7a42: 8262945: [macos] Regression Manual Test for Key Events Fails
  • 99b7b95: 8276205: Shenandoah: CodeCache_lock should always be held for initializing code cache iteration
  • 9771544: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations
  • e265f83: 8276107: Preventive collections trigger before maxing out heap
  • ... and 43 more: https://git.openjdk.java.net/jdk/compare/593401fe8b38bbb8d331a862818fe077af157fcb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2021

@jerboaa Pushed as commit 9971a2c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs hotspot-runtime integrated serviceability
3 participants