8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails

[azvegint]

This test does not fail on Windows and does fail on Linux.

After de-iconification we expect to see the button focused:

Actual look:

Button loses focus on frame.to Front() call, after its removal test passes. There is an open issue for this.

Some cleanup was also made. Testing is green for all platforms.

I am unable to reproduce 8266244 / macosx-aarch64, however it is not removed from the problem list due to its intermittent nature which needs more time to investigate.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6157/head:pull/6157
$ git checkout pull/6157

Update a local copy of the PR:
$ git checkout pull/6157
$ git pull https://git.openjdk.java.net/jdk pull/6157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6157

View PR using the GUI difftool:
$ git pr show -t 6157

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6157.diff

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c9c21ab6)

[mrserb]

What is the reason for the failure on macOS aarch64?

[azvegint]

It seems that it is the same that described by @prsadhuk in #6140 - cursor presence on screenshot:

However it did fail for me only for original test before modifications, and didn't fail after, but I think it still need more investigation under a separate bug.

[prrace]

"Button loses focus on frame.to Front() call, after its removal test passes. There is an open issue for this."

Is it specific to Button ?

You may want to discuss with @azuev-java since he is using toFront to get focus over in #6161 but it isn't a Button there.

[azvegint]

"Button loses focus on frame.to Front() call, after its removal test passes. There is an open issue for this."

Is it specific to Button ?

You may want to discuss with @azuev-java since he is using toFront to get focus over in #6161 but it isn't a Button there.

It is not specific to Button, it may be some other component as well.
A window itself gets the focus on toFront() call, but not the previously focused component inside of it.

#6161 does not have any components and requires only window focus for the test, so it should not face this issue.

[openjdk]

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8079267: [TEST_BUG] Test java/awt/Frame/MiscUndecorated/RepaintTest.java fails

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 213 new commits pushed to the master branch:

• ad3be04: 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766
• e27a67a: 8276930: Update ProblemList
• 73e6d7d: 8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah
• bce35ac: 8276775: ZonedDateTime/OffsetDateTime.toString return invalid ISO-8601 for years <= 1893
• 0c409ca: 8276186: Require getAvailableLocales() methods to include Locale.ROOT
• df02daa: 8269986: Remove +3 from Symbol::identity_hash()
• 2374abd: 8276678: Malformed Javadoc inline tags in JDK source in com/sun/beans/decoder/DocumentHandler.java
• 67c2714: 8276889: Improve compatibility discussion in instanceKlass.cpp
• a5c160c: 8267108: Alternate Subject.getSubject and doAs APIs that do not depend on Security Manager APIs
• ce3ed65: 8273154: Provide a JavadocTester method for non-overlapping, unordered output matching
• ... and 203 more: https://git.openjdk.java.net/jdk/compare/f1f5e2690cb93c07eb8be96a4cbfbf140e8a15e0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[azvegint]

/integrate

[openjdk]

Going to push as commit 6f35eed.
Since your change was applied there have been 221 commits pushed to the master branch:

• 5e98f99: 8276800: Fix table headers in NumericShaper.html
• 2ca4ff8: 8244202: Implementation of JEP 418: Internet-Address Resolution SPI
• c29cab8: 8276112: Inconsistent scalar replacement debug info at safepoints
• aea0967: 8275854: C2: assert(stride_con != 0) failed: missed some peephole opt
• 9862cd0: 8275786: New javadoc option to add script files to generated documentation
• 7a140af: 8276546: [IR Framework] Whitelist and ignore CompileThreshold
• 91bb0d6: 8276796: gc/TestSystemGC.java large pages subtest fails with ZGC
• 08e0fd6: 8276835: G1: make G1EvacFailureObjectsSet::record inline
• ad3be04: 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766
• e27a67a: 8276930: Update ProblemList
• ... and 211 more: https://git.openjdk.java.net/jdk/compare/f1f5e2690cb93c07eb8be96a4cbfbf140e8a15e0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@azvegint Pushed as commit 6f35eed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.