Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter #6158

Closed

Conversation

tobiasholenstein
Copy link
Contributor

@tobiasholenstein tobiasholenstein commented Oct 28, 2021

Changed the type of the displacement in from long to jlong in C2V_VMENTRY_NULL(jobject, readFieldValue, (JNIEnv* env, jobject, jobject object, jobject expected_type, long displacement, jboolean is_volatile, jobject kind_object))


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6158/head:pull/6158
$ git checkout pull/6158

Update a local copy of the PR:
$ git checkout pull/6158
$ git pull https://git.openjdk.java.net/jdk pull/6158/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6158

View PR using the GUI difftool:
$ git pr show -t 6158

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6158.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 28, 2021

👋 Welcome back tobiasholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@tobiasholenstein The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Oct 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 28, 2021

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter

Reviewed-by: chagedorn, dnsimon, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • 157e1d5: 8275856: Remove MetaspaceHandleDeallocations debug switch
  • c9e65f8: 8275440: Remove VirtualSpaceList::is_full()
  • de93b1d: 8257722: Improve "keytool -printcert -jarfile" output
  • 21da218: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
  • 48f3fca: 8275308: Add valueOf(Runtime.Version) factory to SourceVersion
  • c6339cb: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle
  • 5a768f7: 8276054: JMH benchmarks for Fences
  • 6d8fa8f: 8255286: Implement ParametersTypeData::print_data_on fully
  • 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
  • cb989cf: 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/40606021ee6b7d18674e36b3f6249f1ca8a7647e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @dougxc, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

dougxc
dougxc approved these changes Oct 28, 2021
@openjdk openjdk bot added the ready label Oct 28, 2021
@tobiasholenstein
Copy link
Contributor Author

@tobiasholenstein tobiasholenstein commented Oct 28, 2021

/integrate

@tobiasholenstein
Copy link
Contributor Author

@tobiasholenstein tobiasholenstein commented Oct 28, 2021

@chhagedorn and @dougxc thanks for the review!

@openjdk openjdk bot added the sponsor label Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@tobiasholenstein
Your change (at version 58da590) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Oct 29, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2021

Going to push as commit e922023.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 157e1d5: 8275856: Remove MetaspaceHandleDeallocations debug switch
  • c9e65f8: 8275440: Remove VirtualSpaceList::is_full()
  • de93b1d: 8257722: Improve "keytool -printcert -jarfile" output
  • 21da218: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
  • 48f3fca: 8275308: Add valueOf(Runtime.Version) factory to SourceVersion
  • c6339cb: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle
  • 5a768f7: 8276054: JMH benchmarks for Fences
  • 6d8fa8f: 8255286: Implement ParametersTypeData::print_data_on fully
  • 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
  • cb989cf: 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/40606021ee6b7d18674e36b3f6249f1ca8a7647e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2021

@shipilev @tobiasholenstein Pushed as commit e922023.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
4 participants