Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable #616

Closed
wants to merge 1 commit into from

Conversation

kiranoracle
Copy link

@kiranoracle kiranoracle commented Oct 12, 2020

Hi Guys,

Please review the fix to remove jdk.internal.ref.SoftCleanable and WeakCleanable classes as there is no visible usage of them in JDK. Currently, only PhantomCleanable is used.

More information can be viewed at https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/067997.html

Bug: https://bugs.openjdk.java.net/browse/JDK-8251861

Thanks,
Kiran


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/616/head:pull/616
$ git checkout pull/616

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2020

👋 Welcome back kravikumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 12, 2020
@openjdk
Copy link

openjdk bot commented Oct 12, 2020

@kiranoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 12, 2020
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2020

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one. Looks okay.

@openjdk
Copy link

openjdk bot commented Oct 13, 2020

@kiranoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8251861: Remove unused jdk.internal.ref.SoftCleanable and WeakCleanable

Reviewed-by: mchung, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mlchung, @RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2020
@kiranoracle
Copy link
Author

Thanks guys

@kiranoracle
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 13, 2020
@openjdk
Copy link

openjdk bot commented Oct 13, 2020

@kiranoracle
Your change (at version 46dd803) is now ready to be sponsored by a Committer.

@coffeys
Copy link
Contributor

coffeys commented Oct 13, 2020

/sponsor

@openjdk openjdk bot closed this Oct 13, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 13, 2020
@openjdk
Copy link

openjdk bot commented Oct 13, 2020

@coffeys @kiranoracle Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit ba24f96.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kiranoracle kiranoracle deleted the JDK-8251861 branch October 19, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants