Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276107: Preventive collections trigger before maxing out heap #6160

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Oct 28, 2021

Hi all,

can I have reviews for this small fix for an issue where preventive gcs that are supposed to prevent evacuation failure were also started if there were only not enough free committed regions available but more than enough uncommitted regions to expand the heap (to avoid the evacuation failure).

Testing: gha, tier1-3

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276107: Preventive collections trigger before maxing out heap

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6160/head:pull/6160
$ git checkout pull/6160

Update a local copy of the PR:
$ git checkout pull/6160
$ git pull https://git.openjdk.java.net/jdk pull/6160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6160

View PR using the GUI difftool:
$ git pr show -t 6160

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6160.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 28, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 28, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Oct 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 28, 2021

Webrevs

Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good.

I think we should also update the logging below to include num_free_or_available_regions() or maybe even better to just add available, but that would require a new getter if I'm not misstaken.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276107: Preventive collections trigger before maxing out heap

Reviewed-by: sjohanss, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • 5bb1992: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains
  • 158831e: 8274320: os::fork_and_exec() should be using posix_spawn
  • bf2e9ee: 8275080: G1CollectedHeap::expand() returns the wrong value
  • b7104ba: 8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
  • 6875678: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned
  • 5bbc8d3: 8274621: NullPointerException because listenAddress[0] is null
  • 5021a12: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed
  • fe6a202: 8271356: Modify jdb to treat an empty command as a repeat of the previous command
  • cef9db9: 8276039: Remove unnecessary qualifications of java_lang_Class::
  • 13265f9: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/63b9f8c0da2ed3634002f0f67b18555826aeddc4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 29, 2021
@kstefanj
Copy link
Contributor

@kstefanj kstefanj commented Oct 29, 2021

👍

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Nov 1, 2021

Thanks @albertnetymk @kstefanj for your reviews.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

Going to push as commit e265f83.
Since your change was applied there have been 33 commits pushed to the master branch:

  • c8abe35: 8276121: G1: Remove unused and uninitialized _g1h in g1SATBMarkQueueSet.hpp
  • f55e68c: 8275950: Use only _thread_in_vm in ~ThreadBlockInVMPreprocess()
  • 4ac8403: 8276218: JFR: Clean up jdk.jfr.dcmd
  • 89ade1d: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
  • dbf5100: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • 5bb1992: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains
  • 158831e: 8274320: os::fork_and_exec() should be using posix_spawn
  • bf2e9ee: 8275080: G1CollectedHeap::expand() returns the wrong value
  • b7104ba: 8196017: java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails
  • 6875678: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/63b9f8c0da2ed3634002f0f67b18555826aeddc4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

@tschatzl Pushed as commit e265f83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8276107-preventive-gc-before-max-heap branch Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants