8276128: (bf) Remove unused constant ARRAY_BASE_OFFSET from Direct-X-Buffer

[bplb]

Please consider this minor change which would dispense with a vestigial constant.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8276128: (bf) Remove unused constant ARRAY_BASE_OFFSET from Direct-X-Buffer

Reviewers

• Lance Andersen (@LanceAndersen - Reviewer)
• Iris Clark (@irisclark - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6163/head:pull/6163
$ git checkout pull/6163

Update a local copy of the PR:
$ git checkout pull/6163
$ git pull https://git.openjdk.java.net/jdk pull/6163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6163

View PR using the GUI difftool:
$ git pr show -t 6163

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6163.diff

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1d61837d)

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276128: (bf) Remove unused constant ARRAY_BASE_OFFSET from Direct-X-Buffer

Reviewed-by: lancea, iris, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• e922023: 8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter
• 157e1d5: 8275856: Remove MetaspaceHandleDeallocations debug switch
• c9e65f8: 8275440: Remove VirtualSpaceList::is_full()
• de93b1d: 8257722: Improve "keytool -printcert -jarfile" output
• 21da218: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
• 48f3fca: 8275308: Add valueOf(Runtime.Version) factory to SourceVersion

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit 5facaa2.
Since your change was applied there have been 14 commits pushed to the master branch:

• d6d82f5: 8275608: runtime/Metaspace/elastic/TestMetaspaceAllocationMT2 too slow
• a1ec4f9: 6854300: [TEST_BUG] java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java fails in jdk6u14 & jdk7
• 8cc5950: 8251468: X509Certificate.get{Subject,Issuer}AlternativeNames and getExtendedKeyUsage do not throw CertificateParsingException if extension is unparseable
• 4c3491b: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac
• c0cda1d: 8273026: Slow LoginContext.login() on multi threading application
• 15fd8a3: 8276102: JDK-8245095 integration reverted JDK-8247980
• e89b2c0: 8276086: Increase size of metaspace mappings
• 24cf480: 8276047: G1: refactor G1CardSetArrayLocker
• e922023: 8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter
• 157e1d5: 8275856: Remove MetaspaceHandleDeallocations debug switch
• ... and 4 more: https://git.openjdk.java.net/jdk/compare/c6339cb8a255d387bb182ad20dd69f3d460cf1ed...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 5facaa2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.