6854300: [TEST_BUG] java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java fails in jdk6u14 & jdk7

[azvegint]

Test trying to call button.getLocationOnScreen() when its frame not yet fully configured, so the obtained button location is shifted by window's height.

Waiting a bit after setVisible() call fixes the issue. Some cleanup was made also. Testing is green on all platforms.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-6854300: [TEST_BUG] java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java fails in jdk6u14 & jdk7

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6164/head:pull/6164
$ git checkout pull/6164

Update a local copy of the PR:
$ git checkout pull/6164
$ git pull https://git.openjdk.java.net/jdk pull/6164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6164

View PR using the GUI difftool:
$ git pr show -t 6164

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6164.diff

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (be592ef9)
• 00: Full (43506150)

[mrserb]

I think the comp.getLocationOnScreen() should be moved to the EDT, and probably that will solve the problem even w/o delay?

[azvegint]

Done.
Actually it will pass if you add waitForIdle() to the unmodified test, the delay was added just for safety.

[openjdk]

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6854300: [TEST_BUG] java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter_3.java fails in jdk6u14 & jdk7

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 157e1d5: 8275856: Remove MetaspaceHandleDeallocations debug switch
• c9e65f8: 8275440: Remove VirtualSpaceList::is_full()
• de93b1d: 8257722: Improve "keytool -printcert -jarfile" output
• 21da218: 8274848: LambdaMetaFactory::metafactory on REF_invokeSpecial impl method has incorrect behavior
• 48f3fca: 8275308: Add valueOf(Runtime.Version) factory to SourceVersion
• c6339cb: 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle
• 5a768f7: 8276054: JMH benchmarks for Fences
• 6d8fa8f: 8255286: Implement ParametersTypeData::print_data_on fully
• 63b9f8c: 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert.
• cb989cf: 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks
• ... and 2 more: https://git.openjdk.java.net/jdk/compare/abe52aea23d6025737666dfc2b265fdf1aae14bb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[azvegint]

/integrate

[openjdk]

Going to push as commit a1ec4f9.
Since your change was applied there have been 19 commits pushed to the master branch:

• 8cc5950: 8251468: X509Certificate.get{Subject,Issuer}AlternativeNames and getExtendedKeyUsage do not throw CertificateParsingException if extension is unparseable
• 4c3491b: 8017175: [TESTBUG] javax/swing/JPopupMenu/4634626/bug4634626.java sometimes failed on mac
• c0cda1d: 8273026: Slow LoginContext.login() on multi threading application
• 15fd8a3: 8276102: JDK-8245095 integration reverted JDK-8247980
• e89b2c0: 8276086: Increase size of metaspace mappings
• 24cf480: 8276047: G1: refactor G1CardSetArrayLocker
• e922023: 8275909: [JVMCI] c2v_readFieldValue use long instead of jlong for the offset parameter
• 157e1d5: 8275856: Remove MetaspaceHandleDeallocations debug switch
• c9e65f8: 8275440: Remove VirtualSpaceList::is_full()
• de93b1d: 8257722: Improve "keytool -printcert -jarfile" output
• ... and 9 more: https://git.openjdk.java.net/jdk/compare/abe52aea23d6025737666dfc2b265fdf1aae14bb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@azvegint Pushed as commit a1ec4f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.