Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc #6168

Closed
wants to merge 3 commits into from

Conversation

masyano
Copy link

@masyano masyano commented Oct 29, 2021

Could you please review the 8276164 bug fixes?

I suggest adding the missing javadoc of @throws IndexOutOfBoundsException.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6168/head:pull/6168
$ git checkout pull/6168

Update a local copy of the PR:
$ git checkout pull/6168
$ git pull https://git.openjdk.java.net/jdk pull/6168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6168

View PR using the GUI difftool:
$ git pr show -t 6168

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6168.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2021

👋 Welcome back myano! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 29, 2021
@openjdk
Copy link

openjdk bot commented Oct 29, 2021

@masyano The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Oct 29, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 29, 2021

Webrevs

@AlanBateman
Copy link
Contributor

AlanBateman commented Oct 29, 2021

Thanks for separating this from the image I/O issue. For JDK-8276164 then I think we should add the @throws to DataOutput.write, then RAF can inherit it.

@AlanBateman
Copy link
Contributor

AlanBateman commented Oct 29, 2021

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Oct 29, 2021
@openjdk
Copy link

openjdk bot commented Oct 29, 2021

@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@masyano please create a CSR request for issue JDK-8276164. This pull request cannot be integrated until the CSR request is approved.

Yano, Masanori added 2 commits Oct 29, 2021
Copy link
Contributor

@AlanBateman AlanBateman left a comment

This looks okay. I just wonder if we should take a wider pass over the classes in java.io as @throws IOOBE is missing or covered by method descriptions in several places. Also many of the input/output stream classes don't inheritDoc this exception so it doesn't appear in the javadoc of the sub-classes.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@masyano This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 2eafa03: 8276234: Trivially clean up locale-related code
  • 47e7a42: 8262945: [macos] Regression Manual Test for Key Events Fails
  • 99b7b95: 8276205: Shenandoah: CodeCache_lock should always be held for initializing code cache iteration
  • 9771544: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations
  • e265f83: 8276107: Preventive collections trigger before maxing out heap
  • c8abe35: 8276121: G1: Remove unused and uninitialized _g1h in g1SATBMarkQueueSet.hpp
  • f55e68c: 8275950: Use only _thread_in_vm in ~ThreadBlockInVMPreprocess()
  • 4ac8403: 8276218: JFR: Clean up jdk.jfr.dcmd
  • 89ade1d: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
  • dbf5100: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/e89b2c040c68aebf6a099602bc0e04f963e89c84...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 2, 2021
@masyano
Copy link
Author

masyano commented Nov 2, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@masyano
Your change (at version a1cf053) is now ready to be sponsored by a Committer.

@AlanBateman
Copy link
Contributor

AlanBateman commented Nov 2, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 2, 2021

Going to push as commit 9bf3165.
Since your change was applied there have been 29 commits pushed to the master branch:

  • 0488ebd: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • acceffc: 8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time
  • 2eafa03: 8276234: Trivially clean up locale-related code
  • 47e7a42: 8262945: [macos] Regression Manual Test for Key Events Fails
  • 99b7b95: 8276205: Shenandoah: CodeCache_lock should always be held for initializing code cache iteration
  • 9771544: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations
  • e265f83: 8276107: Preventive collections trigger before maxing out heap
  • c8abe35: 8276121: G1: Remove unused and uninitialized _g1h in g1SATBMarkQueueSet.hpp
  • f55e68c: 8275950: Use only _thread_in_vm in ~ThreadBlockInVMPreprocess()
  • 4ac8403: 8276218: JFR: Clean up jdk.jfr.dcmd
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/e89b2c040c68aebf6a099602bc0e04f963e89c84...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@AlanBateman @masyano Pushed as commit 9bf3165.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants