8227077: Test java/awt/Modal/ZOrderTest6271792/ZOrderTest.java fails #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@pankaj-bansal The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Test java/awt/Modal/ZOrderTest6271792/ZOrderTest.java fails on Ubuntu 19.04 and Ubuntu 20.04. The test always fail on mach5 and locally.
Issue: The test create frames and then does robot mouse clicks on frame title. The frames are of less width and on some systems, the robot clicks the minimize button on the frame while clicking the frame title. This results in test failure in further steps.
Fix: Increased the frames dimensions to remove this issue. Also, used variables to define the dimension instead of using the dimension values for all the frames individually.
Along with this change, the fix also does lot of cleanup. For example, added proper robot delays and removed Thread.sleeps. Added autoDelay on Robot, removed lot of code for test machinery and lot of unnecessary functions, disposed the frames at end.
The test is moved from closed to open repo, so looks like a new test. I have run mach5 job with multiple iterations. Link in the JBS.
Progress
Testing
Issue
Download
$ git fetch https://git.openjdk.java.net/jdk pull/617/head:pull/617$ git checkout pull/617