Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8227077: Test java/awt/Modal/ZOrderTest6271792/ZOrderTest.java fails #617

Closed
wants to merge 1 commit into from

Conversation

@pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Oct 12, 2020

Test java/awt/Modal/ZOrderTest6271792/ZOrderTest.java fails on Ubuntu 19.04 and Ubuntu 20.04. The test always fail on mach5 and locally.

Issue: The test create frames and then does robot mouse clicks on frame title. The frames are of less width and on some systems, the robot clicks the minimize button on the frame while clicking the frame title. This results in test failure in further steps.
Fix: Increased the frames dimensions to remove this issue. Also, used variables to define the dimension instead of using the dimension values for all the frames individually.
Along with this change, the fix also does lot of cleanup. For example, added proper robot delays and removed Thread.sleeps. Added autoDelay on Robot, removed lot of code for test machinery and lot of unnecessary functions, disposed the frames at end.
The test is moved from closed to open repo, so looks like a new test. I have run mach5 job with multiple iterations. Link in the JBS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8227077: Test java/awt/Modal/ZOrderTest6271792/ZOrderTest.java fails

Download

$ git fetch https://git.openjdk.java.net/jdk pull/617/head:pull/617
$ git checkout pull/617

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 12, 2020

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2020

@pankaj-bansal The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Oct 12, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 12, 2020

Webrevs

@pankaj-bansal pankaj-bansal deleted the JDK-8227077 branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant