Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8159451: [TEST_BUG] java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java #6177

Closed
wants to merge 4 commits into from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Oct 29, 2021

Added more time to test, removed pixel check during EmbeddedFrame test from OverlappingTestBase.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8159451: [TEST_BUG] java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6177/head:pull/6177
$ git checkout pull/6177

Update a local copy of the PR:
$ git checkout pull/6177
$ git pull https://git.openjdk.java.net/jdk pull/6177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6177

View PR using the GUI difftool:
$ git pr show -t 6177

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6177.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 29, 2021

👋 Welcome back alisenchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 29, 2021

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added client rfr labels Oct 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 29, 2021

Webrevs

@@ -355,7 +355,8 @@ protected void clickAndBlink(Robot robot, Point lLoc) {
protected String failMessage = "The LW component did not received the click.";

private static boolean isValidForPixelCheck(Component component) {
if ((component instanceof java.awt.Scrollbar) || isMac && (component instanceof java.awt.Button)) {
if ((component instanceof java.awt.Scrollbar)
|| (isMac && ((component instanceof java.awt.Button) || (component == null)))) {
Copy link
Contributor

@prrace prrace Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"removed pixel check during EmbeddedFrame test from OverlappingTestBase."

Well you presumably can't pixel check a null component, but why is it null ?
It seems like a test issue for it to be null. Can you explain how this happens ?

Also if this code were to stay it would be better formatted like
if ((component instanceof java.awt.Scrollbar) ||
(isMac && ((component instanceof java.awt.Button) ||
(component == null))))
{

Copy link
Contributor Author

@alisenchung alisenchung Nov 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When component is null it means EmbeddedFrame is currently being tested

@prrace
Copy link
Contributor

@prrace prrace commented Oct 29, 2021

The bug says
This test just need more time to go.
Provided JDK-8158801 is fixed.

but that bug isn't fixed ..

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 29, 2021

@alisenchung This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 27, 2021

@alisenchung This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client rfr
2 participants