Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276218: JFR: Clean up jdk.jfr.dcmd #6183

Closed
wants to merge 1 commit into from
Closed

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Nov 1, 2021

Hi,

Could I have a review of a fix that removes an unessary field and a System.out.println statement that shouldn't be there.

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6183/head:pull/6183
$ git checkout pull/6183

Update a local copy of the PR:
$ git checkout pull/6183
$ git pull https://git.openjdk.java.net/jdk pull/6183/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6183

View PR using the GUI difftool:
$ git pr show -t 6183

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6183.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 1, 2021

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr label Nov 1, 2021
@egahlin egahlin changed the title Initial 8276218: JFR: Clean up jdk.jfr.dcmd Nov 1, 2021
@egahlin egahlin marked this pull request as ready for review Nov 1, 2021
@openjdk openjdk bot added the rfr label Nov 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 1, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276218: JFR: Clean up jdk.jfr.dcmd

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5bb1992: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains
  • 158831e: 8274320: os::fork_and_exec() should be using posix_spawn

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 1, 2021
@egahlin
Copy link
Member Author

@egahlin egahlin commented Nov 1, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

Going to push as commit 4ac8403.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 89ade1d: 8273416: C2: assert(false) failed: bad AD file after JDK-8252372 with UseSSE={0,1}
  • dbf5100: 8276201: Shenandoah: Race results degenerated GC to enter wrong entry point
  • 5bb1992: 8275868: ciReplay: Inlining fails with "unloaded signature classes" due to wrong protection domains
  • 158831e: 8274320: os::fork_and_exec() should be using posix_spawn

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

@egahlin Pushed as commit 4ac8403.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr integrated
2 participants