Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8276036: The value of full_count in the message of insufficient codecache is wrong #6185

Closed

Conversation

tobiasholenstein
Copy link
Contributor

@tobiasholenstein tobiasholenstein commented Nov 1, 2021

The value of full_count (number of times the code heap was full) in the message of insufficient codecache was 0 even though a codecache shortage occurred. This is fixed by simply incrementing the count before the printing.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276036: The value of full_count in the message of insufficient codecache is wrong

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6185/head:pull/6185
$ git checkout pull/6185

Update a local copy of the PR:
$ git checkout pull/6185
$ git pull https://git.openjdk.java.net/jdk pull/6185/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6185

View PR using the GUI difftool:
$ git pr show -t 6185

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6185.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 1, 2021

👋 Welcome back tobiasholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

@tobiasholenstein The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Nov 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 1, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 1, 2021

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276036: The value of full_count in the message of insufficient codecache is wrong

Reviewed-by: kvn, dlong, thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • 8731846: 8276556: ProblemList java/nio/channels/FileChannel/LargeGatheringWrite.java on windows-x64
  • be1ca2b: 8276298: G1: Remove unused G1SegmentedArrayBufferList::add
  • a316c06: 8275730: Relax memory constraint on MultiThreadedRefCounter
  • 6150633: 8276348: Use blessed modifier order in java.base
  • 465d350: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 7439b59: 8276044: ciReplay: C1 does not dump a replay file when using DumpReplay as compile command option
  • 87b926e: 8275086: compiler/c2/irTests/TestPostParseCallDevirtualization.java fails when compiler1 is disabled
  • 2b02b6f: 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
  • bb92fb0: 8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string
  • 6a04899: 8275840: Add test to java/nio/channels/Channels/TransferTo.java to test transfer sizes > 2GB
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/24cf48000ac154eac67b617e2a63557f21032907...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @dean-long, @TobiHartmann, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 1, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

@tobiasholenstein
Copy link
Contributor Author

@tobiasholenstein tobiasholenstein commented Nov 2, 2021

/integrate

@tobiasholenstein
Copy link
Contributor Author

@tobiasholenstein tobiasholenstein commented Nov 2, 2021

@vnkozlov, @dean-long and @TobiHartmann thanks for the reviews!

@openjdk openjdk bot added the sponsor label Nov 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2021

@tobiasholenstein
Your change (at version 1519350) is now ready to be sponsored by a Committer.

@chhagedorn
Copy link
Member

@chhagedorn chhagedorn commented Nov 3, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

Going to push as commit 61cb4bc.
Since your change was applied there have been 52 commits pushed to the master branch:

  • 8731846: 8276556: ProblemList java/nio/channels/FileChannel/LargeGatheringWrite.java on windows-x64
  • be1ca2b: 8276298: G1: Remove unused G1SegmentedArrayBufferList::add
  • a316c06: 8275730: Relax memory constraint on MultiThreadedRefCounter
  • 6150633: 8276348: Use blessed modifier order in java.base
  • 465d350: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 7439b59: 8276044: ciReplay: C1 does not dump a replay file when using DumpReplay as compile command option
  • 87b926e: 8275086: compiler/c2/irTests/TestPostParseCallDevirtualization.java fails when compiler1 is disabled
  • 2b02b6f: 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
  • bb92fb0: 8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string
  • 6a04899: 8275840: Add test to java/nio/channels/Channels/TransferTo.java to test transfer sizes > 2GB
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/24cf48000ac154eac67b617e2a63557f21032907...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@chhagedorn @tobiasholenstein Pushed as commit 61cb4bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
5 participants