New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276205: Shenandoah: CodeCache_lock should always be held for initializing code cache iteration #6192
8276205: Shenandoah: CodeCache_lock should always be held for initializing code cache iteration #6192
Conversation
|
@zhengyu123 The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Looks okay. Do we miss _codecache_snapshot = NULL;
in ~ShenandoahConcurrentRootScanner
?
@zhengyu123 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 111 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Does it matter? |
You tell me, I think it would be full of dangling references after we are done with scanner? The similar reason why we do |
Yea, there is inconsistent among these iterators. The code is in destructors, I don't see it matters, cause accessing dangling references in a deallocated object is a fatal bug. |
/integrate |
Going to push as commit 99b7b95.
Your commit was automatically rebased without conflicts. |
@zhengyu123 Pushed as commit 99b7b95. |
There are few bugs in current implementation:
No CodeCache_lock is held when initialize code cache iterator at safepoints. This is a problem for concurrent GC, since it can initialize a concurrent code cache iterator while holding CodeCache_lock without safepoint check.
Does not notify waiters upon completion of iteration at safepoints
Unnecessary held CodeCache_lock during concurrent code cache iteration.
Test:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6192/head:pull/6192
$ git checkout pull/6192
Update a local copy of the PR:
$ git checkout pull/6192
$ git pull https://git.openjdk.java.net/jdk pull/6192/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6192
View PR using the GUI difftool:
$ git pr show -t 6192
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6192.diff