Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8276239: Better tables in java.util.random package summary #6196

Closed
wants to merge 1 commit into from

Conversation

LudwikJaniuk
Copy link
Contributor

@LudwikJaniuk LudwikJaniuk commented Nov 1, 2021

The tables are now striped, and they use row headers (which is a nice-to-have for accessibility).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276239: Better tables in java.util.random package summary

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6196/head:pull/6196
$ git checkout pull/6196

Update a local copy of the PR:
$ git checkout pull/6196
$ git pull https://git.openjdk.java.net/jdk pull/6196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6196

View PR using the GUI difftool:
$ git pr show -t 6196

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6196.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2021

👋 Welcome back LudwikJaniuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 1, 2021

@LudwikJaniuk The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review labels Nov 1, 2021
@openjdk
Copy link

openjdk bot commented Nov 1, 2021

@LudwikJaniuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276239: Better tables in java.util.random package summary

Reviewed-by: jlaskey

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 92be9d8: 8276236: Table headers missing in Formatter api docs
  • 9bf3165: 8276164: RandomAccessFile#write method could throw IndexOutOfBoundsException that is not described in javadoc
  • 0488ebd: 8276105: C2: Conv(D|F)2(I|L)Nodes::Ideal should handle rounding correctly
  • acceffc: 8273704: DrawStringWithInfiniteXform.java failed : drawString with InfiniteXform transform takes long time
  • 2eafa03: 8276234: Trivially clean up locale-related code
  • 47e7a42: 8262945: [macos] Regression Manual Test for Key Events Fails
  • 99b7b95: 8276205: Shenandoah: CodeCache_lock should always be held for initializing code cache iteration
  • 9771544: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations
  • e265f83: 8276107: Preventive collections trigger before maxing out heap
  • c8abe35: 8276121: G1: Remove unused and uninitialized _g1h in g1SATBMarkQueueSet.hpp
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/4ac8403f9a4cedcb5d56bcd34a6bbfa51d67ca18...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JimLaskey) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 1, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2021

Webrevs

@LudwikJaniuk
Copy link
Contributor Author

LudwikJaniuk commented Nov 2, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@LudwikJaniuk
Your change (at version 5d027df) is now ready to be sponsored by a Committer.

@LudwikJaniuk
Copy link
Contributor Author

LudwikJaniuk commented Nov 8, 2021

@JimLaskey Could I ask you to sponsor?

@cl4es
Copy link
Member

cl4es commented Nov 8, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 8, 2021

Going to push as commit d8b0dee.
Since your change was applied there have been 92 commits pushed to the master branch:

  • fc0fe25: 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit
  • 3934fe5: 8275847: Scheduling fails with "too many D-U pinch points" on small method
  • 44047f8: 8274328: C2: Redundant CFG edges fixup in block ordering
  • 8849154: 8275846: read_base_archive_name() could read past the end of buffer
  • 2653cfb: 8276688: Remove JLinkReproducibleXXXTest from ProblemList.txt
  • c7095b2: 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters
  • ed7ecca: 8254739: G1: Optimize evacuation failure for regions with few failed objects
  • 59c3dcc: 8276746: Add section on reproducible builds in building.md
  • 0e0dd33: 8276129: PretouchTask should page-align the chunk size
  • a472433: 8276572: Fake libsyslookup.so library causes tooling issues
  • ... and 82 more: https://git.openjdk.java.net/jdk/compare/4ac8403f9a4cedcb5d56bcd34a6bbfa51d67ca18...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 8, 2021
@openjdk
Copy link

openjdk bot commented Nov 8, 2021

@cl4es @LudwikJaniuk Pushed as commit d8b0dee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants