Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254158: Consolidate per-platform stack overflow handling code #620

Closed
wants to merge 1 commit into from

Conversation

@coleenp
Copy link
Contributor

@coleenp coleenp commented Oct 12, 2020

Moved the duplicated code from posix based platform/cpu combinations into os_posix.cpp. Left a little function to determine frame at stack banging point for compiled methods (you can suggest a better name for it) to capture the difference.

There are a bit of ifdefs but now there are less copies.

Tested with tier1-3 and stack overflow tests in vmTestbase/nsk/stress/stack on linux-x86-debug,macosx-x86-debug,windows-x86-debug. Built aarch64, arm32, ppc, s390, and zero. Testing on these platforms would be welcome.

Thanks,
Coleen


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8254158: Consolidate per-platform stack overflow handling code

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/620/head:pull/620
$ git checkout pull/620

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 12, 2020

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2020

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 12, 2020

Webrevs

Loading

Copy link
Contributor

@fparain fparain left a comment

Looks good to me. Thank you for refactoring this code.

Fred

Loading

Copy link
Member

@hseigel hseigel left a comment

The changes look good. Thanks for consolidating this code.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2020

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254158: Consolidate per-platform stack overflow handling code

Reviewed-by: fparain, hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 13, 2020
@coleenp
Copy link
Contributor Author

@coleenp coleenp commented Oct 13, 2020

Thanks Fred and Harold.

/integrate

Loading

@openjdk openjdk bot closed this Oct 13, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 13, 2020

@coleenp Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit ba5dc67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@coleenp coleenp deleted the stack-overflow branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants