Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276173: Clean up and remove unneeded casts in HeapDumper #6211

Closed
wants to merge 2 commits into from

Conversation

lkorinth
Copy link
Contributor

@lkorinth lkorinth commented Nov 2, 2021

HeapDumper does a lot of unneeded casts. Some arguments should be const. Headers are not correctly sorted. Comment about identifier size on Windows and Solaris is not true.

First I cleaned up casting in the "union casting", but then I decided it was better to create a temporary bit_cast that we can use until we get the proper one in c++20.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276173: Clean up and remove unneeded casts in HeapDumper

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6211/head:pull/6211
$ git checkout pull/6211

Update a local copy of the PR:
$ git checkout pull/6211
$ git pull https://git.openjdk.java.net/jdk pull/6211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6211

View PR using the GUI difftool:
$ git pr show -t 6211

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6211.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 2, 2021

👋 Welcome back lkorinth! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 2, 2021

@lkorinth The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Nov 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 2, 2021

Webrevs

@lkorinth
Copy link
Contributor Author

@lkorinth lkorinth commented Nov 4, 2021

/label add serviceability

@openjdk openjdk bot added the serviceability label Nov 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2021

@lkorinth
The serviceability label was successfully added.

coleenp
coleenp approved these changes Nov 4, 2021
Copy link
Contributor

@coleenp coleenp left a comment

This looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2021

@lkorinth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276173: Clean up and remove unneeded casts in HeapDumper

Reviewed-by: coleenp, hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 424 new commits pushed to the master branch:

  • 1533b81: 8276629: Use blessed modifier order in core-libs code
  • 7bb2173: 8276199: java/nio/channels/FileChannel/LargeGatheringWrite.java fails to terminate correctly
  • b57715a: 8276573: Use blessed modifier order in jdk.javadoc
  • bf4ddf9: 8276338: Minor improve of wording for String.to(Lower|Upper)Case
  • afb502e: 8276550: Use SHA256 hash in build.tools.depend.Depend
  • 49b7b2e: 8276640: Use blessed modifier order in jfr code
  • 5acff75: 8276429: CodeHeapState::print_names() fails with "assert(klass->is_loader_alive()) failed: must be alive"
  • a6fa6ed: 8268779: ZGC: runtime/InternalApi/ThreadCpuTimesDeadlock.java#id1 failed with "OutOfMemoryError: Java heap space"
  • 19075b3: 8275788: Create code element with suitable attributes for code snippets
  • 7de653e: 8276301: G1: Refine implementation of G1CardSetFreePool::memory_sizes()
  • ... and 414 more: https://git.openjdk.java.net/jdk/compare/05d38604a2c620dcaf8682f02dae2fddab8e0c0b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 4, 2021
hseigel
hseigel approved these changes Nov 4, 2021
Copy link
Member

@hseigel hseigel left a comment

Looks good!
Thanks, Harold

@lkorinth
Copy link
Contributor Author

@lkorinth lkorinth commented Nov 5, 2021

Thanks Coleen and Harold!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

Going to push as commit 3c0faa7.
Since your change was applied there have been 438 commits pushed to the master branch:

  • 323d201: 8275506: Rename allocated_on_stack to allocated_on_stack_or_embedded
  • 96c396b: 8276151: AArch64: Incorrect result for double to int vector conversion
  • 7281861: 8272065: jcmd cannot rely on the old core reflection implementation which will be changed after JEP 416
  • 8e17ce0: 8275185: Remove dead code and clean up jvmstat LocalVmManager
  • 396132f: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds
  • 9ad4d3d: 8276025: Hotspot's libsvml.so may conflict with user dependency
  • e21b5c7: 8276650: GenGraphs does not produce deterministic output
  • 7b1916e: 8233557: [TESTBUG] DoubleClickTitleBarTest.java fails on macOs
  • 8ec80c4: 8276653: Missing row headers in j.l.Character docs
  • 7e87f94: 8276652: Missing row headers in MethodHandles.Lookup docs
  • ... and 428 more: https://git.openjdk.java.net/jdk/compare/05d38604a2c620dcaf8682f02dae2fddab8e0c0b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@lkorinth Pushed as commit 3c0faa7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@lkorinth lkorinth deleted the _8276173 branch Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated serviceability
3 participants