Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276367: ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java #6214

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 2, 2021

A trivial fix to ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276367: ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6214/head:pull/6214
$ git checkout pull/6214

Update a local copy of the PR:
$ git checkout pull/6214
$ git pull https://git.openjdk.java.net/jdk pull/6214/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6214

View PR using the GUI difftool:
$ git pr show -t 6214

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6214.diff

…ineWithoutBytecodeCorruption/TestDescription.java
@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add serviceability

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 2, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@dcubed-ojdk
The serviceability label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review November 2, 2021 16:42
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276367: ProblemList vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8fc16f1: 8275729: Qualified method names in CodeHeap Analytics
  • fa4ce82: 8276260: (se) Remove java/nio/channels/Selector/Wakeup.java from ProblemList (win)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@dcubed-ojdk
Copy link
Member Author

@bplb - Thanks for the fast review.

/integrate

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

Going to push as commit 01105d6.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8fc16f1: 8275729: Qualified method names in CodeHeap Analytics
  • fa4ce82: 8276260: (se) Remove java/nio/channels/Selector/Wakeup.java from ProblemList (win)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 2, 2021
@openjdk
Copy link

openjdk bot commented Nov 2, 2021

@dcubed-ojdk Pushed as commit 01105d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Nov 2, 2021

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8276367 branch November 2, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
2 participants