Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276298: G1: Fix or remove G1SegmentedArrayBufferList::add #6223

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Nov 3, 2021

This is minor removal of unused method G1SegmentedArrayBufferList::add.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276298: G1: Fix or remove G1SegmentedArrayBufferList::add

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6223/head:pull/6223
$ git checkout pull/6223

Update a local copy of the PR:
$ git checkout pull/6223
$ git pull https://git.openjdk.java.net/jdk pull/6223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6223

View PR using the GUI difftool:
$ git pr show -t 6223

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6223.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 3, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 3, 2021

Webrevs

@Hamlin-Li Hamlin-Li closed this Nov 3, 2021
@Hamlin-Li Hamlin-Li deleted the refine-G1CardSetFreePool-memory_sizes branch Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc rfr
1 participant