Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276298: G1: Remove unused G1SegmentedArrayBufferList::add #6224

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Nov 3, 2021

This is minor removal of unused method G1SegmentedArrayBufferList::add.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276298: G1: Remove unused G1SegmentedArrayBufferList::add

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6224/head:pull/6224
$ git checkout pull/6224

Update a local copy of the PR:
$ git checkout pull/6224
$ git pull https://git.openjdk.java.net/jdk pull/6224/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6224

View PR using the GUI difftool:
$ git pr show -t 6224

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6224.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 3, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 3, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm, thanks, and trivial. Please adjust the title of this PR to the CR title I renamed this to (just "remove") and then you can immediately push (trivial removal rule).

@Hamlin-Li Hamlin-Li changed the title 8276298: G1: Fix or remove G1SegmentedArrayBufferList::add 8276298: G1: Remove unused G1SegmentedArrayBufferList::add Nov 3, 2021
@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Nov 3, 2021

Thanks Thomas for your review.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276298: G1: Remove unused G1SegmentedArrayBufferList::add

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • a316c06: 8275730: Relax memory constraint on MultiThreadedRefCounter
  • 6150633: 8276348: Use blessed modifier order in java.base
  • 465d350: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 7439b59: 8276044: ciReplay: C1 does not dump a replay file when using DumpReplay as compile command option
  • 87b926e: 8275086: compiler/c2/irTests/TestPostParseCallDevirtualization.java fails when compiler1 is disabled
  • 2b02b6f: 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

Going to push as commit be1ca2b.
Since your change was applied there have been 6 commits pushed to the master branch:

  • a316c06: 8275730: Relax memory constraint on MultiThreadedRefCounter
  • 6150633: 8276348: Use blessed modifier order in java.base
  • 465d350: 8276157: C2: Compiler stack overflow during escape analysis on Linux x86_32
  • 7439b59: 8276044: ciReplay: C1 does not dump a replay file when using DumpReplay as compile command option
  • 87b926e: 8275086: compiler/c2/irTests/TestPostParseCallDevirtualization.java fails when compiler1 is disabled
  • 2b02b6f: 8274942: AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@Hamlin-Li Pushed as commit be1ca2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the remove-G1SegmentedArrayBufferList-add branch Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
2 participants