Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276540: Howl Full CardSet container iteration marks too many cards #6229

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Nov 3, 2021

Hi all,

can I have reviews for this change that fixes how many cards are being iterated over during Howl Full CardSet container iteration? There is no need to iterate over max_cards_in_region() cards, it is sufficient to iterate just over the area that this Howl partition represents, i.e. num_cards_in_howl_bitmap().

I will change the way to iterate over this card set container within the howl container in JDK-8276548 to keep this change small.

Testing: tier1-5 (with JDK-8276548).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276540: Howl Full CardSet container iteration marks too many cards

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6229/head:pull/6229
$ git checkout pull/6229

Update a local copy of the PR:
$ git checkout pull/6229
$ git pull https://git.openjdk.java.net/jdk pull/6229/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6229

View PR using the GUI difftool:
$ git pr show -t 6229

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6229.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 3, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 3, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276540: Howl Full CardSet container iteration marks too many cards

Reviewed-by: ayang, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

  • 5448139: 8271056: C2: "assert(no_dead_loop) failed: dead loop detected" due to cmoving identity
  • 0395e4e: 8276768: Snippet copy feature should use button instead of link
  • d8b0dee: 8276239: Better tables in java.util.random package summary
  • fc0fe25: 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit
  • 3934fe5: 8275847: Scheduling fails with "too many D-U pinch points" on small method
  • 44047f8: 8274328: C2: Redundant CFG edges fixup in block ordering
  • 8849154: 8275846: read_base_archive_name() could read past the end of buffer
  • 2653cfb: 8276688: Remove JLinkReproducibleXXXTest from ProblemList.txt
  • c7095b2: 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters
  • ed7ecca: 8254739: G1: Optimize evacuation failure for regions with few failed objects
  • ... and 59 more: https://git.openjdk.java.net/jdk/compare/7439b59b5a6816269b16d210ef10779fc9def8e2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 3, 2021
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Nov 8, 2021

Thanks @albertnetymk @kstefanj for your reviews

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2021

Going to push as commit ff6863c.
Since your change was applied there have been 69 commits pushed to the master branch:

  • 5448139: 8271056: C2: "assert(no_dead_loop) failed: dead loop detected" due to cmoving identity
  • 0395e4e: 8276768: Snippet copy feature should use button instead of link
  • d8b0dee: 8276239: Better tables in java.util.random package summary
  • fc0fe25: 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit
  • 3934fe5: 8275847: Scheduling fails with "too many D-U pinch points" on small method
  • 44047f8: 8274328: C2: Redundant CFG edges fixup in block ordering
  • 8849154: 8275846: read_base_archive_name() could read past the end of buffer
  • 2653cfb: 8276688: Remove JLinkReproducibleXXXTest from ProblemList.txt
  • c7095b2: 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters
  • ed7ecca: 8254739: G1: Optimize evacuation failure for regions with few failed objects
  • ... and 59 more: https://git.openjdk.java.net/jdk/compare/7439b59b5a6816269b16d210ef10779fc9def8e2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 8, 2021
@openjdk openjdk bot added integrated and removed ready labels Nov 8, 2021
@tschatzl tschatzl deleted the submit/8276540-howl-full-bitmap branch Nov 8, 2021
@openjdk openjdk bot removed the rfr label Nov 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2021

@tschatzl Pushed as commit ff6863c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants