8254365: ciMethod.hpp should not include methodHandles.hpp

[iklam]

ciMethod.hpp includes methodHandles.hpp. This is probably a typo as ciMethod.hpp doesn't use the MethodHandles class. Instead, it uses methodHandle which is declared in runtime/handles.hpp.

As usual, I had to fix a few .cpp files that used the MethodHandles class but did not explicitly include methodHandles.hpp.

Tested with mach5 build tiers 1-5.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8254365: ciMethod.hpp should not include methodHandles.hpp

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 187dc78
• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to 187dc78

Download

$ git fetch https://git.openjdk.java.net/jdk pull/623/head:pull/623
$ git checkout pull/623

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (3496d80)
• 00: Full (187dc78)

[dholmes-ora]

Seems okay. There are a couple of changes unrelated to the bug synopsis. :)

Thanks,
David

[openjdk]

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254365: ciMethod.hpp should not include methodHandles.hpp

Reviewed-by: dholmes, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• d50e0de: 8254722: bsd_zero builds broken after JDK-8253717

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[iklam]

Seems okay. There are a couple of changes unrelated to the bug synopsis. :)

Thanks,
David

There are 2 things that I didn't mention:

• java.cpp needs vmThread.hpp (for the zero build only) after this fix. vmThread.hpp used to be recursively included via methodHandles.hpp -> entry_zero.hpp -> zeroInterpreter.hpp -> abstractInterpreter.hpp -> vmThread.hpp.
• ciEnv.hpp needs systemDictionary.hpp after this fix. systemDictionary.hpp used to be recursively included via methodHandles.hpp.

[iklam]

/integrate

[openjdk]

@iklam Since your change was applied there has been 1 commit pushed to the master branch:

• d50e0de: 8254722: bsd_zero builds broken after JDK-8253717

Your commit was automatically rebased without conflicts.

Pushed as commit a098037.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.