Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276548: Use range based visitor for Howl-Full cards #6230

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Nov 3, 2021

Hi all,

can I have reviews for this change that improves the way G1 iterates over Howl-Full containers (i.e. "Full" cardsetptrs within a Howl cardset container)? Instead of calling the visitor method do_card to mark a single card for all cards in the range, just call the range-based visitor method do_card_range. This is also a little bit more efficient.

This change is a requirement for JDK-8275056.

Testing: tier1-5

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276548: Use range based visitor for Howl-Full cards

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6230/head:pull/6230
$ git checkout pull/6230

Update a local copy of the PR:
$ git checkout pull/6230
$ git pull https://git.openjdk.java.net/jdk pull/6230/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6230

View PR using the GUI difftool:
$ git pr show -t 6230

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6230.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 3, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 3, 2021
@tschatzl tschatzl marked this pull request as ready for review Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

⚠️ @tschatzl This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the rfr label Nov 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276548: Use range based visitor for Howl-Full cards

Reviewed-by: ayang, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 5, 2021
Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good.

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Nov 8, 2021

Thanks @albertnetymk @kstefanj for your reviews.

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Nov 8, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2021

Going to push as commit 7320b77.
Since your change was applied there have been 7 commits pushed to the master branch:

  • ea23e73: 8249004: Reduce ThreadsListHandle overhead in relation to direct handshakes
  • c815c5c: 8276209: Some call sites doesn't pass the parameter 'size' to SharedRuntime::dtrace_object_alloc(_base)
  • 71c4b19: 8276562: Fix to JDK-8263155 left out the help text changes
  • cc2cac1: 8274686: java.util.UUID#hashCode() should use Long.hashCode()
  • 0c2d00b: 8275097: Wrong span of the 'default' tag
  • fa754b8: 8276149: jshell throws EOF error when throwing exception inside switch expression
  • 4c14edd: 8274734: the method jdk.jshell.SourceCodeAnalysis documentation not working

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2021

@tschatzl Pushed as commit 7320b77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the submit/8276548-range-based-visitor branch Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants