-
Notifications
You must be signed in to change notification settings - Fork 6k
8276429: CodeHeapState::print_names() fails with "assert(klass->is_loader_alive()) failed: must be alive" #6234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ader_alive()) failed: must be alive"
👋 Welcome back eastig! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. I will test it before approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class name retrieval now follows the same steps as method name and method signature. You should be on the safe side now. I can't formally approve without knowing Vladimir's secret tests complete OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After infrastructure hiccup tests finally passed.
Please integrate and I will sponsor.
@eastig This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @RealLucy) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit 5acff75.
Your commit was automatically rebased without conflicts. |
This PR fixes
applications/kitchensink/Kitchensink.java
regression introduced by JDK-8275729.The requirement for a method holder to be alive is relaxed to the holder not to be NULL.
If holder's name is not available the format of the string used for the name is the same as for unavailable method's name and signature, instead of the default string:
<unknown>
.Testing:
make run-test TEST=tier1_serviceability
: Passedmake run-test TEST=hotspot_tier2_serviceability
: Passedmake run-test TEST=serviceability/dcmd/compiler/CodeHeapAnalyticsMethodNames.java
: PassedProgress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6234/head:pull/6234
$ git checkout pull/6234
Update a local copy of the PR:
$ git checkout pull/6234
$ git pull https://git.openjdk.java.net/jdk pull/6234/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6234
View PR using the GUI difftool:
$ git pr show -t 6234
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6234.diff