Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276429: CodeHeapState::print_names() fails with "assert(klass->is_loader_alive()) failed: must be alive" #6234

Closed
wants to merge 1 commit into from

Conversation

eastig
Copy link
Contributor

@eastig eastig commented Nov 3, 2021

This PR fixes applications/kitchensink/Kitchensink.java regression introduced by JDK-8275729.
The requirement for a method holder to be alive is relaxed to the holder not to be NULL.
If holder's name is not available the format of the string used for the name is the same as for unavailable method's name and signature, instead of the default string: <unknown>.
Testing:

  • make run-test TEST=tier1_serviceability: Passed
  • make run-test TEST=hotspot_tier2_serviceability: Passed
  • make run-test TEST=serviceability/dcmd/compiler/CodeHeapAnalyticsMethodNames.java: Passed

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276429: CodeHeapState::print_names() fails with "assert(klass->is_loader_alive()) failed: must be alive"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6234/head:pull/6234
$ git checkout pull/6234

Update a local copy of the PR:
$ git checkout pull/6234
$ git pull https://git.openjdk.java.net/jdk pull/6234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6234

View PR using the GUI difftool:
$ git pr show -t 6234

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6234.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 3, 2021

👋 Welcome back eastig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@eastig The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler label Nov 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 3, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good. I will test it before approval.

Copy link
Contributor

@RealLucy RealLucy left a comment

class name retrieval now follows the same steps as method name and method signature. You should be on the safe side now. I can't formally approve without knowing Vladimir's secret tests complete OK.

Copy link
Contributor

@vnkozlov vnkozlov left a comment

After infrastructure hiccup tests finally passed.
Please integrate and I will sponsor.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 3, 2021

@eastig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276429: CodeHeapState::print_names() fails with "assert(klass->is_loader_alive()) failed: must be alive"

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • c62b347: 8276623: JDK-8275650 accidentally pushed "out" file
  • a1f4c42: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868
  • 9eadcbb: 8276217: Harmonize StrictMath intrinsics handling
  • fb0be81: 8276096: Simplify Unsafe.{load|store}Fence fallbacks by delegating to fullFence
  • 558ee40: 8276615: Update CR number of some tests in ProblemList-zgc.txt
  • 603bba2: 8271420: Extend CDS custom loader support to Windows platform
  • ce8c767: 8276220: Reduce excessive allocations in DateTimeFormatter
  • 0ab910d: 8276066: Reset LoopPercentProfileLimit for x86 due to suboptimal performance
  • f3320d2: 8276588: Change "ccc" to "CSR" in HotSpot sources
  • 32895ac: 8275650: Problemlist java/io/File/createTempFile/SpecialTempFile.java for Windows 11
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/bb92fb02ca8c5795989065a9037748dc39ed77db...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @RealLucy) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 3, 2021
@eastig
Copy link
Contributor Author

@eastig eastig commented Nov 4, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2021

@eastig
Your change (at version c8e0129) is now ready to be sponsored by a Committer.

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Nov 4, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2021

Going to push as commit 5acff75.
Since your change was applied there have been 29 commits pushed to the master branch:

  • a6fa6ed: 8268779: ZGC: runtime/InternalApi/ThreadCpuTimesDeadlock.java#id1 failed with "OutOfMemoryError: Java heap space"
  • 19075b3: 8275788: Create code element with suitable attributes for code snippets
  • 7de653e: 8276301: G1: Refine implementation of G1CardSetFreePool::memory_sizes()
  • ee49963: 8275534: com.sun.net.httpserver.BasicAuthenticator should check whether "realm" is a quoted string
  • 3613ce7: 8275586: Zero: Simplify interpreter initialization
  • c62b347: 8276623: JDK-8275650 accidentally pushed "out" file
  • a1f4c42: 8276227: ciReplay: SIGSEGV if classfile for replay compilation is not present after JDK-8275868
  • 9eadcbb: 8276217: Harmonize StrictMath intrinsics handling
  • fb0be81: 8276096: Simplify Unsafe.{load|store}Fence fallbacks by delegating to fullFence
  • 558ee40: 8276615: Update CR number of some tests in ProblemList-zgc.txt
  • ... and 19 more: https://git.openjdk.java.net/jdk/compare/bb92fb02ca8c5795989065a9037748dc39ed77db...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2021

@vnkozlov @eastig Pushed as commit 5acff75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
3 participants