New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276199: java/nio/channels/FileChannel/LargeGatheringWrite.java fails to terminate correctly #6238
Conversation
… to terminate correctly
The test appears to require about 80s-90s in the CI of which approximately 90% is from the beginning until just after the gathering write. A repeat of 100 tests with the default timeout (480s) showed no failures. Other runs with 10 repeats for 84s, 120s, and 240s showed no failures. |
👋 Welcome back bpb! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to monitor it but okay for now.
@bplb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 7bb2173.
Your commit was automatically rebased without conflicts. |
Double the test timeout and remove the test from the ProblemList.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6238/head:pull/6238
$ git checkout pull/6238
Update a local copy of the PR:
$ git checkout pull/6238
$ git pull https://git.openjdk.java.net/jdk pull/6238/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6238
View PR using the GUI difftool:
$ git pr show -t 6238
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6238.diff