New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276623: JDK-8275650 accidentally pushed "out" file #6248
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and trivial.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this Aleksey. The fact it was considered a binary file made it easy to overlook in the PR.
Yes this is a trivial fix.
David
Thanks for quick reviews! /integrate |
See the commit: 32895ac
I think this is a trivial fix to remove the accidental addition. I only found this because my local filesystem also has "out" file, and git complained about that pull is about to overwrite it.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6248/head:pull/6248
$ git checkout pull/6248
Update a local copy of the PR:
$ git checkout pull/6248
$ git pull https://git.openjdk.java.net/jdk pull/6248/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6248
View PR using the GUI difftool:
$ git pr show -t 6248
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6248.diff