Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit #6256

Closed
wants to merge 1 commit into from

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Nov 4, 2021

This PR implements the fix as suggested by Adam Farley, which reads:

Note: Looks to be as simple as adding jaccessinspector-32 and jaccesswalker-32 to TOOLS_NOT_TO_TEST at the top of HelpFlagsTest.java, as the non-32bit versions are already there.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6256/head:pull/6256
$ git checkout pull/6256

Update a local copy of the PR:
$ git checkout pull/6256
$ git pull https://git.openjdk.java.net/jdk pull/6256/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6256

View PR using the GUI difftool:
$ git pr show -t 6256

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6256.diff

@sormuras sormuras changed the title JDK-8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit 8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit Nov 4, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 4, 2021

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2021

@sormuras The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-runtime core-libs labels Nov 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 4, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine to me.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2021

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273235: tools/launcher/HelpFlagsTest.java Fails on Windows 32bit

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 134 new commits pushed to the master branch:

  • 7bb2173: 8276199: java/nio/channels/FileChannel/LargeGatheringWrite.java fails to terminate correctly
  • b57715a: 8276573: Use blessed modifier order in jdk.javadoc
  • bf4ddf9: 8276338: Minor improve of wording for String.to(Lower|Upper)Case
  • afb502e: 8276550: Use SHA256 hash in build.tools.depend.Depend
  • 49b7b2e: 8276640: Use blessed modifier order in jfr code
  • 5acff75: 8276429: CodeHeapState::print_names() fails with "assert(klass->is_loader_alive()) failed: must be alive"
  • a6fa6ed: 8268779: ZGC: runtime/InternalApi/ThreadCpuTimesDeadlock.java#id1 failed with "OutOfMemoryError: Java heap space"
  • 19075b3: 8275788: Create code element with suitable attributes for code snippets
  • 7de653e: 8276301: G1: Refine implementation of G1CardSetFreePool::memory_sizes()
  • ee49963: 8275534: com.sun.net.httpserver.BasicAuthenticator should check whether "realm" is a quoted string
  • ... and 124 more: https://git.openjdk.java.net/jdk/compare/3ff085e2967508ad312c9d32fa908807aefe69ee...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 4, 2021
@sormuras
Copy link
Member Author

@sormuras sormuras commented Nov 4, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 4, 2021

@sormuras
Your change (at version 2be54b3) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Nov 5, 2021

I think it is pretty trivial. If there are no other comments today, I'll sponsor this.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Nov 8, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2021

Going to push as commit fc0fe25.
Since your change was applied there have been 167 commits pushed to the master branch:

  • 3934fe5: 8275847: Scheduling fails with "too many D-U pinch points" on small method
  • 44047f8: 8274328: C2: Redundant CFG edges fixup in block ordering
  • 8849154: 8275846: read_base_archive_name() could read past the end of buffer
  • 2653cfb: 8276688: Remove JLinkReproducibleXXXTest from ProblemList.txt
  • c7095b2: 8276207: Properties.loadFromXML/storeToXML works incorrectly for supplementary characters
  • ed7ecca: 8254739: G1: Optimize evacuation failure for regions with few failed objects
  • 59c3dcc: 8276746: Add section on reproducible builds in building.md
  • 0e0dd33: 8276129: PretouchTask should page-align the chunk size
  • a472433: 8276572: Fake libsyslookup.so library causes tooling issues
  • b01f107: 8276252: java/nio/channels/Channels/TransferTo.java failed with OOM java heap space error
  • ... and 157 more: https://git.openjdk.java.net/jdk/compare/3ff085e2967508ad312c9d32fa908807aefe69ee...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2021

@shipilev @sormuras Pushed as commit fc0fe25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs hotspot-runtime integrated
2 participants