8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac

[pankaj-bansal]

Test java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac fails on Mac. The test fails on my local machine (macOS BigSur) always and on mach5 also. The test uses Robot for mouse clicks and there is no delay or autoDelay set on Robot.

The fix adds set autoDelay on the robot. Along with this, some other cleanup is done. The test passes after the changes on my local mac and mach5 (Link in the JBS)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6273/head:pull/6273
$ git checkout pull/6273

Update a local copy of the PR:
$ git checkout pull/6273
$ git pull https://git.openjdk.java.net/jdk pull/6273/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6273

View PR using the GUI difftool:
$ git pr show -t 6273

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6273.diff

[bridgekeeper]

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@pankaj-bansal The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c98c3793)
• 00: Full (841ecaa8)

[mrserb]

I think the d.setVisible(true) will be blocked and the next "EventQueue.invokeLater" will be executed after the dialog will be closed, unlike the old code where the invokeLater was executed after dialog became visible.

[pankaj-bansal]

Yes, looks like that. I have reverted this change and ran the test in CI multiple times. Link in JBS

[openjdk]

@pankaj-bansal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

• dde959d: 8276808: java/nio/channels/Channels/TransferTo.java timed out
• daf77eb: 8276337: Use override specifier in HeapDumper
• 93692ea: 8274395: Use enhanced-for instead of plain 'for' in jdk.internal.jvmstat
• e35abe3: 8256208: Javadoc's generated overview does not show classes of unnamed package
• f65db88: 8276841: Add support for Visual Studio 2022
• c27afb3: 8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java
• e198594: 8250678: ModuleDescriptor.Version parsing treats empty segments inconsistently
• 4bd5bfd: 8276731: Metaspace chunks are uncommitted twice
• 5c7f77c: 8276850: Remove outdated comment in HeapRegionManager::par_iterate
• 945f408: 8276098: Do precise BOT updates in G1 evacuation phase
• ... and 38 more: https://git.openjdk.java.net/jdk/compare/3c0faa73522bd004b66cb9e477f43e15a29842e6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[pankaj-bansal]

/integrate

[openjdk]

Going to push as commit a60e912.
Since your change was applied there have been 48 commits pushed to the master branch:

• dde959d: 8276808: java/nio/channels/Channels/TransferTo.java timed out
• daf77eb: 8276337: Use override specifier in HeapDumper
• 93692ea: 8274395: Use enhanced-for instead of plain 'for' in jdk.internal.jvmstat
• e35abe3: 8256208: Javadoc's generated overview does not show classes of unnamed package
• f65db88: 8276841: Add support for Visual Studio 2022
• c27afb3: 8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java
• e198594: 8250678: ModuleDescriptor.Version parsing treats empty segments inconsistently
• 4bd5bfd: 8276731: Metaspace chunks are uncommitted twice
• 5c7f77c: 8276850: Remove outdated comment in HeapRegionManager::par_iterate
• 945f408: 8276098: Do precise BOT updates in G1 evacuation phase
• ... and 38 more: https://git.openjdk.java.net/jdk/compare/3c0faa73522bd004b66cb9e477f43e15a29842e6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@pankaj-bansal Pushed as commit a60e912.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.