Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276746: Add section on reproducible builds in building.md #6279

Closed
wants to merge 2 commits into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Nov 5, 2021

Reproducible builds are all the vogue. The JDK has been making great strides in getting there, but still has some way to go. However, to get as close as possible, some special configuration is needed.

This has been "tribal knowledge" of a few persons in the build team. It needs to be properly documented to help other users wanting to create reproducible builds of the JDK.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276746: Add section on reproducible builds in building.md

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6279/head:pull/6279
$ git checkout pull/6279

Update a local copy of the PR:
$ git checkout pull/6279
$ git pull https://git.openjdk.java.net/jdk pull/6279/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6279

View PR using the GUI difftool:
$ git pr show -t 6279

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6279.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2021

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@magicus The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Nov 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2021

Webrevs

erikj79
erikj79 approved these changes Nov 5, 2021
doc/building.md Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276746: Add section on reproducible builds in building.md

Reviewed-by: erikj, sgehwolf, aleonard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • a472433: 8276572: Fake libsyslookup.so library causes tooling issues
  • b01f107: 8276252: java/nio/channels/Channels/TransferTo.java failed with OOM java heap space error
  • 92d2176: 8273967: gtest os.dll_address_to_function_and_library_name_vm fails on macOS12

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 5, 2021
jerboaa
jerboaa approved these changes Nov 5, 2021
Copy link
Contributor

@jerboaa jerboaa left a comment

LGTM. Thanks for documenting it!

Copy link

@andrew-m-leonard andrew-m-leonard left a comment

Looks good Magnus

@magicus
Copy link
Member Author

@magicus magicus commented Nov 5, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

Going to push as commit 59c3dcc.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 0e0dd33: 8276129: PretouchTask should page-align the chunk size
  • a472433: 8276572: Fake libsyslookup.so library causes tooling issues
  • b01f107: 8276252: java/nio/channels/Channels/TransferTo.java failed with OOM java heap space error
  • 92d2176: 8273967: gtest os.dll_address_to_function_and_library_name_vm fails on macOS12

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@magicus Pushed as commit 59c3dcc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@magicus magicus deleted the readme-reproducible branch Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
4 participants