Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276790: Rename GenericCDSFileMapHeader::_base_archive_path_offset #6288

Conversation

iklam
Copy link
Member

@iklam iklam commented Nov 7, 2021

Please review this trivial change that improves consistency in the source code:

In the GenericCDSFileMapHeader structure, rename

_base_archive_path_offset => _base_archive_name_offset

I also changed the names used by various tests accordingly.

Running tiers 1-4


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276790: Rename GenericCDSFileMapHeader::_base_archive_path_offset

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6288/head:pull/6288
$ git checkout pull/6288

Update a local copy of the PR:
$ git checkout pull/6288
$ git pull https://git.openjdk.java.net/jdk pull/6288/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6288

View PR using the GUI difftool:
$ git pr show -t 6288

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6288.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 7, 2021

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 7, 2021

@iklam The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime label Nov 7, 2021
@iklam iklam marked this pull request as ready for review Nov 8, 2021
@openjdk openjdk bot added the rfr label Nov 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 8, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Ioi,

Renaming looks good.

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Nov 8, 2021

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276790: Rename GenericCDSFileMapHeader::_base_archive_path_offset

Reviewed-by: dholmes, ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 14d66bd: 8276654: element-list order is non deterministic
  • 905e3e8: 8231490: Ugly racy writes to ZipUtils.defaultBuf
  • e383d26: 8275199: Bogus warning generated for serializable records
  • 7e73bca: 8276408: Deprecate Runtime.exec methods with a single string command line argument
  • 75adf54: 8276306: jdk/jshell/CustomInputToolBuilder.java fails intermittently on storage acquisition
  • 7320b77: 8276548: Use range based visitor for Howl-Full cards
  • ea23e73: 8249004: Reduce ThreadsListHandle overhead in relation to direct handshakes
  • c815c5c: 8276209: Some call sites doesn't pass the parameter 'size' to SharedRuntime::dtrace_object_alloc(_base)
  • 71c4b19: 8276562: Fix to JDK-8263155 left out the help text changes
  • cc2cac1: 8274686: java.util.UUID#hashCode() should use Long.hashCode()
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/884915496f7bfe754279f1644603131c64f192b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 8, 2021
Copy link
Member

@calvinccheung calvinccheung left a comment

LGTM.

@iklam
Copy link
Member Author

@iklam iklam commented Nov 9, 2021

Thanks @dholmes-ora and @calvinccheung for the review.
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 9, 2021

Going to push as commit 8747882.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 38e6d5d: 8276677: Malformed Javadoc inline tags in JDK source in javax/net/ssl
  • a7dedb5: 8276772: Refine javax.lang.model docs
  • 14d66bd: 8276654: element-list order is non deterministic
  • 905e3e8: 8231490: Ugly racy writes to ZipUtils.defaultBuf
  • e383d26: 8275199: Bogus warning generated for serializable records
  • 7e73bca: 8276408: Deprecate Runtime.exec methods with a single string command line argument
  • 75adf54: 8276306: jdk/jshell/CustomInputToolBuilder.java fails intermittently on storage acquisition
  • 7320b77: 8276548: Use range based visitor for Howl-Full cards
  • ea23e73: 8249004: Reduce ThreadsListHandle overhead in relation to direct handshakes
  • c815c5c: 8276209: Some call sites doesn't pass the parameter 'size' to SharedRuntime::dtrace_object_alloc(_base)
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/884915496f7bfe754279f1644603131c64f192b3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 9, 2021

@iklam Pushed as commit 8747882.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
4 participants