New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8254671: ZGC: Remove unused roots iterator types #629
Conversation
|
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good an trivial
@@ -35,21 +35,9 @@ | |||
|
|||
class ZRootsIteratorClosure; | |||
|
|||
typedef OopStorage::ParState<true /* concurrent */, false /* is_const */> ZOopStorageIterator; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want you could also remove #include "gc/shared/oopStorageParState.hpp" from this file (though it's implicitly included, so will not matter more than fewer includes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, will fix!
@pliden This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
@pliden Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 6fe209b. |
The types ZOopStorageIterator, ZSerialOopsDo and ZParallelWeakOopsDo are no longer used and can be removed.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/629/head:pull/629
$ git checkout pull/629