Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276678: Malformed Javadoc inline tags in JDK source in com/sun/beans/decoder/DocumentHandler.java #6298

Closed
wants to merge 1 commit into from

Conversation

alisenchung
Copy link
Contributor

@alisenchung alisenchung commented Nov 8, 2021

fixed malformed inline tags


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276678: Malformed Javadoc inline tags in JDK source in com/sun/beans/decoder/DocumentHandler.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6298/head:pull/6298
$ git checkout pull/6298

Update a local copy of the PR:
$ git checkout pull/6298
$ git pull https://git.openjdk.java.net/jdk pull/6298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6298

View PR using the GUI difftool:
$ git pr show -t 6298

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6298.diff

…/decoder/DocumentHandler.java

Reviewed-by: alichung
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2021

👋 Welcome back alisenchung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 8, 2021
@openjdk
Copy link

openjdk bot commented Nov 8, 2021

@alisenchung The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 8, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2021

Webrevs

@mrserb
Copy link
Member

mrserb commented Nov 8, 2021

Please check other classes in the jdk desktop module as well. There are 7 such issues.

@aivanov-jdk
Copy link
Member

aivanov-jdk commented Nov 8, 2021

Please check other classes in the jdk desktop module as well. There are 7 such issues.

A similar issue is being reviewed as #6290, it includes 4 files.
Are these split between JBS subcomponents?

@alisenchung
Copy link
Contributor Author

alisenchung commented Nov 9, 2021

Please check other classes in the jdk desktop module as well. There are 7 such issues.

A similar issue is being reviewed as #6290, it includes 4 files. Are these split between JBS subcomponents?

Looks like Prasanta already fixed the other 5 issues

mrserb
mrserb approved these changes Nov 9, 2021
@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276678: Malformed Javadoc inline tags in JDK source in com/sun/beans/decoder/DocumentHandler.java

Reviewed-by: serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 206 new commits pushed to the master branch:

  • 67c2714: 8276889: Improve compatibility discussion in instanceKlass.cpp
  • a5c160c: 8267108: Alternate Subject.getSubject and doAs APIs that do not depend on Security Manager APIs
  • ce3ed65: 8273154: Provide a JavadocTester method for non-overlapping, unordered output matching
  • f561d3c: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 38ec3a1: 8276672: Cannot build hsdis on WSL
  • 55b36c6: 8276825: hotspot/runtime/SelectionResolution test errors
  • 0f23c6a: 8276926: Use String.valueOf() when initializing File.separator and File.pathSeparator
  • a0b8445: 8276846: JDK-8273416 is incomplete for UseSSE=1
  • a3f710e: 8276215: Intrinsics matchers should handle native method flags better
  • 0f463a7: 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32
  • ... and 196 more: https://git.openjdk.java.net/jdk/compare/f1f5e2690cb93c07eb8be96a4cbfbf140e8a15e0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 9, 2021
@alisenchung
Copy link
Contributor Author

alisenchung commented Nov 10, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 10, 2021
@openjdk
Copy link

openjdk bot commented Nov 10, 2021

@alisenchung
Your change (at version 85138fd) is now ready to be sponsored by a Committer.

@aivanov-jdk
Copy link
Member

aivanov-jdk commented Nov 10, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 10, 2021

Going to push as commit 2374abd.
Since your change was applied there have been 206 commits pushed to the master branch:

  • 67c2714: 8276889: Improve compatibility discussion in instanceKlass.cpp
  • a5c160c: 8267108: Alternate Subject.getSubject and doAs APIs that do not depend on Security Manager APIs
  • ce3ed65: 8273154: Provide a JavadocTester method for non-overlapping, unordered output matching
  • f561d3c: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 38ec3a1: 8276672: Cannot build hsdis on WSL
  • 55b36c6: 8276825: hotspot/runtime/SelectionResolution test errors
  • 0f23c6a: 8276926: Use String.valueOf() when initializing File.separator and File.pathSeparator
  • a0b8445: 8276846: JDK-8273416 is incomplete for UseSSE=1
  • a3f710e: 8276215: Intrinsics matchers should handle native method flags better
  • 0f463a7: 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32
  • ... and 196 more: https://git.openjdk.java.net/jdk/compare/f1f5e2690cb93c07eb8be96a4cbfbf140e8a15e0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 10, 2021
@openjdk
Copy link

openjdk bot commented Nov 10, 2021

@aivanov-jdk @alisenchung Pushed as commit 2374abd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants