Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276833: G1: Make G1EvacFailureRegions::par_iterate const #6302


Copy link

@Hamlin-Li Hamlin-Li commented Nov 9, 2021

This is a trivial code enhancement to make G1EvacFailureRegions::par_iterate const.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8276833: G1: Make G1EvacFailureRegions::par_iterate const



Using git

Checkout this PR locally:
$ git fetch pull/6302/head:pull/6302
$ git checkout pull/6302

Update a local copy of the PR:
$ git checkout pull/6302
$ git pull pull/6302/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6302

View PR using the GUI difftool:
$ git pr show -t 6302

Using diff file

Download this PR as a diff file:

Copy link

@bridgekeeper bridgekeeper bot commented Nov 9, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 9, 2021
Copy link

@openjdk openjdk bot commented Nov 9, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 9, 2021
Copy link

@mlbridge mlbridge bot commented Nov 9, 2021


@Hamlin-Li Hamlin-Li changed the title 8276833: G1: make G1EvacFailureRegions::par_iterate const 8276833: G1: Make G1EvacFailureRegions::par_iterate const Nov 9, 2021
Copy link

@tschatzl tschatzl left a comment


Copy link

@openjdk openjdk bot commented Nov 9, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8276833: G1: Make G1EvacFailureRegions::par_iterate const

Reviewed-by: tschatzl, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 945f408: 8276098: Do precise BOT updates in G1 evacuation phase
  • 8747882: 8276790: Rename GenericCDSFileMapHeader::_base_archive_path_offset
  • 38e6d5d: 8276677: Malformed Javadoc inline tags in JDK source in javax/net/ssl
  • a7dedb5: 8276772: Refine javax.lang.model docs
  • 14d66bd: 8276654: element-list order is non deterministic
  • 905e3e8: 8231490: Ugly racy writes to ZipUtils.defaultBuf
  • e383d26: 8275199: Bogus warning generated for serializable records
  • 7e73bca: 8276408: Deprecate Runtime.exec methods with a single string command line argument
  • 75adf54: 8276306: jdk/jshell/ fails intermittently on storage acquisition
  • 7320b77: 8276548: Use range based visitor for Howl-Full cards
  • ... and 14 more:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 9, 2021
Copy link

@Hamlin-Li Hamlin-Li commented Nov 10, 2021

Thanks @tschatzl @albertnetymk for your reviews.


Copy link

@openjdk openjdk bot commented Nov 10, 2021

Going to push as commit c8b0ee6.
Since your change was applied there have been 38 commits pushed to the master branch:

  • 0699220: 8268882: C2: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc
  • d7012fb: 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary
  • f9024d0: 8230130: javadoc search result dialog shows cut off headers for long results
  • 055de6f: 8223358: Incorrect HTML structure in annotation pages
  • a60e912: 8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac
  • dde959d: 8276808: java/nio/channels/Channels/ timed out
  • daf77eb: 8276337: Use override specifier in HeapDumper
  • 93692ea: 8274395: Use enhanced-for instead of plain 'for' in jdk.internal.jvmstat
  • e35abe3: 8256208: Javadoc's generated overview does not show classes of unnamed package
  • f65db88: 8276841: Add support for Visual Studio 2022
  • ... and 28 more:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 10, 2021
Copy link

@openjdk openjdk bot commented Nov 10, 2021

@Hamlin-Li Pushed as commit c8b0ee6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the make-G1EvacFailureRegions-par_iterate-const branch Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
hotspot-gc integrated
3 participants