-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32 #6307
8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32 #6307
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks Alan. Need another reviewer, I think. |
No, one Reviewer working in the area is okay. |
Ok, cool. /integrate |
Going to push as commit 0f463a7.
Your commit was automatically rebased without conflicts. |
x86_32 takes a path that requires
newFileChannel
implemented inTestProvider
. Otherwise the test fails with the exception. The implementation is the same as fornewByteChannel
.Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6307/head:pull/6307
$ git checkout pull/6307
Update a local copy of the PR:
$ git checkout pull/6307
$ git pull https://git.openjdk.java.net/jdk pull/6307/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6307
View PR using the GUI difftool:
$ git pr show -t 6307
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6307.diff