8276846: JDK-8273416 is incomplete for UseSSE=1

[shipilev]

When doing the fix for JDK-8273416, I made a mistake of not running with UseSSE=1. That one highlights a bug (see JIRA for reproducer): I have misjudged that float and double args are handled at the same SSE levels, which they are not. doubles uses FPU with SSE={0,1}, and float uses FPU with SSE={0}. See for example the blurbs in MacroAssembler::{load|store}_{float|double}. So the new predicate for regFPR argument mishandles UseSSE=1 case: we should not allow castFF_PR to match then.

Additional testing:

• Linux x86_32 tier1 with -XX:UseAVX=0 -XX:UseSSE=0
• Linux x86_32 tier1 with -XX:UseAVX=0 -XX:UseSSE=1
• Linux x86_32 tier1 with -XX:UseAVX=0 -XX:UseSSE=2
• Linux x86_32 tier1 with -XX:UseAVX=0 -XX:UseSSE=3
• Linux x86_32 tier1 with -XX:UseAVX=0 -XX:UseSSE=4
• Linux x86_32 tier1 with -XX:UseAVX=1 -XX:UseSSE=4
• Linux x86_32 tier1 with -XX:UseAVX=2 -XX:UseSSE=4

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8276846: JDK-8273416 is incomplete for UseSSE=1

Reviewers

• Nils Eliasson (@neliasso - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6308/head:pull/6308
$ git checkout pull/6308

Update a local copy of the PR:
$ git checkout pull/6308
$ git pull https://git.openjdk.java.net/jdk pull/6308/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6308

View PR using the GUI difftool:
$ git pr show -t 6308

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6308.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4dbe27e2)

[neliasso]

Looks good!

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276846: JDK-8273416 is incomplete for UseSSE=1

Reviewed-by: neliasso, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• daf77eb: 8276337: Use override specifier in HeapDumper
• 93692ea: 8274395: Use enhanced-for instead of plain 'for' in jdk.internal.jvmstat
• e35abe3: 8256208: Javadoc's generated overview does not show classes of unnamed package
• f65db88: 8276841: Add support for Visual Studio 2022
• c27afb3: 8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java
• e198594: 8250678: ModuleDescriptor.Version parsing treats empty segments inconsistently
• 4bd5bfd: 8276731: Metaspace chunks are uncommitted twice
• 5c7f77c: 8276850: Remove outdated comment in HeapRegionManager::par_iterate
• 945f408: 8276098: Do precise BOT updates in G1 evacuation phase

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vnkozlov]

Good.

[shipilev]

Thanks, folks!

/integrate

[openjdk]

Going to push as commit a0b8445.
Since your change was applied there have been 24 commits pushed to the master branch:

• a3f710e: 8276215: Intrinsics matchers should handle native method flags better
• 0f463a7: 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32
• e01d6d0: 8276679: Malformed Javadoc inline tags in JDK source in javax/swing
• fd0a25e: 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager
• 403f318: 8276854: Windows GHA builds fail due to broken Cygwin
• e91e9d8: 8276721: G1: Refine G1EvacFailureObjectsSet::iterate
• 8822d41: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily
• c1e41fe: 8276842: G1: Only calculate size in bytes from words when needed
• c8b0ee6: 8276833: G1: Make G1EvacFailureRegions::par_iterate const
• 0699220: 8268882: C2: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc
• ... and 14 more: https://git.openjdk.java.net/jdk/compare/8747882e4cb3af58062923bf830f9de877bdb03d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit a0b8445.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.