New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276546: [IR Framework] Whitelist and ignore CompileThreshold #6312
Conversation
|
@chhagedorn The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@chhagedorn This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 79 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks Vladimir and Nils for your reviews! |
/integrate |
Going to push as commit 7a140af.
Your commit was automatically rebased without conflicts. |
@chhagedorn Pushed as commit 7a140af. |
This patch whitelists
CompileThreshold
and ignores it if passed as JTreg VM/Java option flag to a test. The reason to do this is that our CI executes-XX:-TieredCompilation
in combination withCompileThreshold
and therefore IR matching will not be performed (becauseCompileThreshold
is not whitelisted). This patch changes this.Setting
CompileThreshold
withTestFramework::addFlags/runWithFlags()
will normally apply the flag.Thanks,
Christian
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6312/head:pull/6312
$ git checkout pull/6312
Update a local copy of the PR:
$ git checkout pull/6312
$ git pull https://git.openjdk.java.net/jdk pull/6312/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 6312
View PR using the GUI difftool:
$ git pr show -t 6312
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6312.diff