Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java #6313

Closed
wants to merge 1 commit into from

Conversation

wangweij
Copy link
Contributor

@wangweij wangweij commented Nov 9, 2021

The test was added in JDK-8237218 to confirm that Java impl is used when verifying a signature. It is useless now since the native implementation is completely removed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6313/head:pull/6313
$ git checkout pull/6313

Update a local copy of the PR:
$ git checkout pull/6313
$ git pull https://git.openjdk.java.net/jdk pull/6313/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6313

View PR using the GUI difftool:
$ git pr show -t 6313

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6313.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@wangweij
Copy link
Contributor Author

wangweij commented Nov 9, 2021

/integrate auto

@openjdk openjdk bot added rfr Pull request is ready for review auto labels Nov 9, 2021
@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@wangweij This pull request will be automatically integrated when it is ready

@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 9, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 9, 2021

Webrevs

Copy link
Contributor

@ascarpino ascarpino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276863: Remove test/jdk/sun/security/ec/ECDSAJavaVerify.java

Reviewed-by: ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 228 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 9, 2021
@openjdk
Copy link

openjdk bot commented Nov 9, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2021

Going to push as commit c27afb3.
Since your change was applied there have been 228 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 9, 2021
@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@openjdk[bot] Pushed as commit c27afb3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wangweij wangweij deleted the 8276863 branch November 9, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants