Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276864: Update boot JDKs to 17.0.1 in GHA #6314

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 9, 2021

Current GHA runs at 17 GA, which misses fixes from 17.0.1.

Additional testing:

  • GHA builds are fine
  • GHA tests are fine

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6314/head:pull/6314
$ git checkout pull/6314

Update a local copy of the PR:
$ git checkout pull/6314
$ git pull https://git.openjdk.java.net/jdk pull/6314/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6314

View PR using the GUI difftool:
$ git pr show -t 6314

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6314.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 9, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Nov 9, 2021
@shipilev shipilev marked this pull request as ready for review Nov 9, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 9, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 9, 2021

Webrevs

erikj79
erikj79 approved these changes Nov 9, 2021
@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276864: Update boot JDKs to 17.0.1 in GHA

Reviewed-by: erikj, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 55b36c6: 8276825: hotspot/runtime/SelectionResolution test errors
  • 0f23c6a: 8276926: Use String.valueOf() when initializing File.separator and File.pathSeparator
  • a0b8445: 8276846: JDK-8273416 is incomplete for UseSSE=1
  • a3f710e: 8276215: Intrinsics matchers should handle native method flags better
  • 0f463a7: 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32
  • e01d6d0: 8276679: Malformed Javadoc inline tags in JDK source in javax/swing
  • fd0a25e: 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager
  • 403f318: 8276854: Windows GHA builds fail due to broken Cygwin
  • e91e9d8: 8276721: G1: Refine G1EvacFailureObjectsSet::iterate
  • 8822d41: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/8747882e4cb3af58062923bf830f9de877bdb03d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 9, 2021
@shipilev
Copy link
Member Author

shipilev commented Nov 10, 2021

Thanks, Erik. Anyone else wants/needs to review this?

@shipilev
Copy link
Member Author

shipilev commented Nov 10, 2021

Ok, good, thanks. GHA are clean. I am integrating.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 10, 2021

Going to push as commit f561d3c.
Since your change was applied there have been 28 commits pushed to the master branch:

  • 38ec3a1: 8276672: Cannot build hsdis on WSL
  • 55b36c6: 8276825: hotspot/runtime/SelectionResolution test errors
  • 0f23c6a: 8276926: Use String.valueOf() when initializing File.separator and File.pathSeparator
  • a0b8445: 8276846: JDK-8273416 is incomplete for UseSSE=1
  • a3f710e: 8276215: Intrinsics matchers should handle native method flags better
  • 0f463a7: 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32
  • e01d6d0: 8276679: Malformed Javadoc inline tags in JDK source in javax/swing
  • fd0a25e: 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager
  • 403f318: 8276854: Windows GHA builds fail due to broken Cygwin
  • e91e9d8: 8276721: G1: Refine G1EvacFailureObjectsSet::iterate
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/8747882e4cb3af58062923bf830f9de877bdb03d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 10, 2021
@openjdk
Copy link

openjdk bot commented Nov 10, 2021

@shipilev Pushed as commit f561d3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8276864-17.0.1-gha branch Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
3 participants