8276854: Windows GHA builds fail due to broken Cygwin

[AnirvanSarkar]

Use version 3.2.0 of cygwin instead of latest version 3.3.2 on GitHub Actions.
make SEGVs on the latest version.

Version number format obtained from https://cygwin.com/packages/summary/cygwin.html

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8276854: Windows GHA builds fail due to broken Cygwin

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6319/head:pull/6319
$ git checkout pull/6319

Update a local copy of the PR:
$ git checkout pull/6319
$ git pull https://git.openjdk.java.net/jdk pull/6319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6319

View PR using the GUI difftool:
$ git pr show -t 6319

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6319.diff

[bridgekeeper]

👋 Welcome back asarkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AnirvanSarkar The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (55d5ea49)

[RealCLanger]

Cool. Thanks for doing this fix. And thanks to @shipilev for chasing this down.

[openjdk]

@AnirvanSarkar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276854: Windows GHA builds fail due to broken Cygwin

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 0699220: 8268882: C2: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc
• d7012fb: 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary
• f9024d0: 8230130: javadoc search result dialog shows cut off headers for long results
• 055de6f: 8223358: Incorrect HTML structure in annotation pages
• a60e912: 8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac
• dde959d: 8276808: java/nio/channels/Channels/TransferTo.java timed out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[AnirvanSarkar]

/integrate

[openjdk]

@AnirvanSarkar
Your change (at version 55d5ea4) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit 403f318.
Since your change was applied there have been 10 commits pushed to the master branch:

• e91e9d8: 8276721: G1: Refine G1EvacFailureObjectsSet::iterate
• 8822d41: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily
• c1e41fe: 8276842: G1: Only calculate size in bytes from words when needed
• c8b0ee6: 8276833: G1: Make G1EvacFailureRegions::par_iterate const
• 0699220: 8268882: C2: assert(n->outcnt() != 0 || C->top() == n || n->is_Proj()) failed: No dead instructions after post-alloc
• d7012fb: 8276880: Remove java/lang/RuntimeTests/exec/ExecWithDir as unnecessary
• f9024d0: 8230130: javadoc search result dialog shows cut off headers for long results
• 055de6f: 8223358: Incorrect HTML structure in annotation pages
• a60e912: 8198626: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails on mac
• dde959d: 8276808: java/nio/channels/Channels/TransferTo.java timed out

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @AnirvanSarkar Pushed as commit 403f318.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[shipilev]

The patch looks okay.

But what just happened here process-wise? Please do not take the issue out of assignee's hands without asking first, and definitely do NOT push the fix until the original assignee at least performs some sort of handover. Especially don't do that in the span of less than 24 hours, where the assignee might just be asleep. I also suspect the build infra changes require more reviews, anyway. Don't rush it, folks!

[tstuefe]

The patch looks okay.

But what just happened here process-wise? Please do not take the issue out of assignee's hands without asking first, and definitely do NOT push the fix until the original assignee at least performs some sort of handover. Especially don't do that in the span of less than 24 hours, where the assignee might just be asleep.

Yes, that was odd. Please don't reassign JBS issues unless you either talk with the assignee or it has been clearly abandoned.

[AnirvanSarkar]

It is my mistake. Sorry for rushing and breaking the etiquette.
I will ensure that this does not happen again.

[shipilev]

It is my mistake. Sorry for rushing and breaking the etiquette. I will ensure that this does not happen again.

Good, thanks. No harm done in this particular case, as the patch is definitely sensible. I'll handle the backports...

[mlbridge]

Mailing list message from Magnus Ihse Bursie on build-dev:

https://openjdk.java.net/census#build

On 2021-11-10 08:48, Aleksey Shipilev wrote:

On Tue, 9 Nov 2021 20:47:29 GMT, Anirvan Sarkar <asarkar at openjdk.org> wrote:

Use version `3.2.0` of `cygwin` instead of latest version `3.3.2` on GitHub Actions.
`make` SEGVs on the latest version.

Version number format obtained from https://cygwin.com/packages/summary/cygwin.html
The patch looks okay.

But what just happened here process-wise? Please do *not* take the issue out of assignee's hands without asking first, and definitely do *NOT* push the fix until the original assignee at least performs some sort of handover. Especially don't do that in the span of less than 24 hours, where the assignee might just be asleep. I also suspect the build infra changes require more reviews, anyway. Don't rush it, folks!

I would like to add to Aleksey's comment that the ideal is that you get
a review from someone in the Build Group
(https://openjdk.java.net/census#build). You definitely need to wait 24h
if you have no Build Group member reviews., unless the PR is extremely
urgent.

/Magnus

[RealCLanger]

It is my mistake. Sorry for rushing and breaking the etiquette. I will ensure that this does not happen again.

That was also my mistake (probably even more than Anirvan's) since I sponsored this too early and I should have taken care for all the points mentioned above. Sorry folks!