Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276835: G1: make G1EvacFailureObjectsSet::record inline #6322

Conversation

Hamlin-Li
Copy link

@Hamlin-Li Hamlin-Li commented Nov 10, 2021

This is a minor improvement to make G1EvacFailureObjectsSet::record inline, which was not.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276835: G1: Make G1EvacFailureObjectsSet::record inline

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6322/head:pull/6322
$ git checkout pull/6322

Update a local copy of the PR:
$ git checkout pull/6322
$ git pull https://git.openjdk.java.net/jdk pull/6322/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6322

View PR using the GUI difftool:
$ git pr show -t 6322

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6322.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 10, 2021

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2021

@Hamlin-Li The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc label Nov 10, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 10, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Lgtm.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2021

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276835: G1: make G1EvacFailureObjectsSet::record inline

Reviewed-by: tschatzl, ayang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • ce3ed65: 8273154: Provide a JavadocTester method for non-overlapping, unordered output matching
  • f561d3c: 8276864: Update boot JDKs to 17.0.1 in GHA
  • 38ec3a1: 8276672: Cannot build hsdis on WSL
  • 55b36c6: 8276825: hotspot/runtime/SelectionResolution test errors
  • 0f23c6a: 8276926: Use String.valueOf() when initializing File.separator and File.pathSeparator
  • a0b8445: 8276846: JDK-8273416 is incomplete for UseSSE=1
  • a3f710e: 8276215: Intrinsics matchers should handle native method flags better
  • 0f463a7: 8276845: (fs) java/nio/file/spi/SetDefaultProvider.java fails on x86_32
  • e01d6d0: 8276679: Malformed Javadoc inline tags in JDK source in javax/swing
  • fd0a25e: 8276805: java/awt/print/PrinterJob/CheckPrivilege.java fails due to disabled SecurityManager
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/e91e9d853272ea8f5ce490f2f0c971fd40795d74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 10, 2021
@Hamlin-Li
Copy link
Author

@Hamlin-Li Hamlin-Li commented Nov 11, 2021

Thansk @tschatzl @albertnetymk for your reviews.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2021

Going to push as commit 08e0fd6.
Since your change was applied there have been 20 commits pushed to the master branch:

  • ad3be04: 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766
  • e27a67a: 8276930: Update ProblemList
  • 73e6d7d: 8276801: gc/stress/CriticalNativeStress.java fails intermittently with Shenandoah
  • bce35ac: 8276775: ZonedDateTime/OffsetDateTime.toString return invalid ISO-8601 for years <= 1893
  • 0c409ca: 8276186: Require getAvailableLocales() methods to include Locale.ROOT
  • df02daa: 8269986: Remove +3 from Symbol::identity_hash()
  • 2374abd: 8276678: Malformed Javadoc inline tags in JDK source in com/sun/beans/decoder/DocumentHandler.java
  • 67c2714: 8276889: Improve compatibility discussion in instanceKlass.cpp
  • a5c160c: 8267108: Alternate Subject.getSubject and doAs APIs that do not depend on Security Manager APIs
  • ce3ed65: 8273154: Provide a JavadocTester method for non-overlapping, unordered output matching
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/e91e9d853272ea8f5ce490f2f0c971fd40795d74...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 11, 2021

@Hamlin-Li Pushed as commit 08e0fd6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Hamlin-Li Hamlin-Li deleted the make-G1EvacFailureObjectsSet-record-inline branch Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants