Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277536: Use String.blank in jdk.javadoc where applicable #6323

Closed

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Nov 10, 2021

There are couple of places where manual cycle is used to check if String contains non-whitespaces characters.
Since Java 11 we have String.isBlank() which could be used instead.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8277536: Use String.blank in jdk.javadoc where applicable

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6323/head:pull/6323
$ git checkout pull/6323

Update a local copy of the PR:
$ git checkout pull/6323
$ git pull https://git.openjdk.java.net/jdk pull/6323/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6323

View PR using the GUI difftool:
$ git pr show -t 6323

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6323.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 10, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 10, 2021

@turbanoff The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc label Nov 10, 2021
@turbanoff turbanoff changed the title [PATCH] Remove redundant boxing in jdk.javadoc.internal.doclint.Checker [PATCH] Use String.blank in jdk.javadoc where applicable Nov 12, 2021
@turbanoff turbanoff changed the title [PATCH] Use String.blank in jdk.javadoc where applicable 8277536: Use String.blank in jdk.javadoc where applicable Nov 22, 2021
@openjdk openjdk bot added the rfr label Nov 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Nov 24, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277536: Use String.blank in jdk.javadoc where applicable

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 208 new commits pushed to the master branch:

  • 7e54d06: 8277165: jdeps --multi-release --print-module-deps fails if module-info.class in different versioned directories
  • eb4d886: 8277504: Use String.stripTrailing instead of hand-crafted method in SwingUtilities2
  • 9879920: 8277825: Remove unused ReferenceProcessorPhaseTimes::_sub_phases_total_time_ms
  • f788834: 8277786: G1: Rename log2_card_region_per_heap_region used in G1CardSet
  • 3034ae8: 8277631: ZGC: CriticalMetaspaceAllocation asserts
  • f0136ec: 8275687: runtime/CommandLine/PrintTouchedMethods test shouldn't catch RuntimeException
  • 21e302a: 8270435: UT: MonitorUsedDeflationThresholdTest failed: did not find too_many string in output
  • a81e4fc: 8258117: jar tool sets the time stamp of module-info.class entries to the current time
  • 26472bd: 8277811: ProblemList vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic001/TestDescription.java
  • b5841ba: 8277806: 4 tools/jar failures per platform after JDK-8272728
  • ... and 198 more: https://git.openjdk.java.net/jdk/compare/403f3185f0988dcf6ef4e857d6659533bfa2943f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jonathan-gibbons) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 24, 2021
@turbanoff
Copy link
Member Author

@turbanoff turbanoff commented Nov 26, 2021

/integrate

@openjdk openjdk bot added the sponsor label Nov 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 26, 2021

@turbanoff
Your change (at version ff17b82) is now ready to be sponsored by a Committer.

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented Dec 7, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

Going to push as commit bb50b92.
Since your change was applied there have been 375 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Dec 7, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 7, 2021

@jonathan-gibbons @turbanoff Pushed as commit bb50b92.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the redundant_boxing_javadoc_Checker branch Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated javadoc
2 participants