Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276927: [PPC64] Port shenandoahgc to linux on ppc64le #6325

Closed
wants to merge 2 commits into from

Conversation

Quaffel
Copy link
Member

@Quaffel Quaffel commented Nov 10, 2021

Port the Shenandoah garbage collector JDK-8241457 to linux on ppc64le.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8276927: [ppc64] Port shenandoahgc to linux on ppc64le

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/6325/head:pull/6325
$ git checkout pull/6325

Update a local copy of the PR:
$ git checkout pull/6325
$ git pull https://git.openjdk.java.net/jdk pull/6325/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6325

View PR using the GUI difftool:
$ git pr show -t 6325

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/6325.diff

@Quaffel Quaffel changed the title 8276927: [PPC64] Port shenandoahgc to linux on ppc64 8276927: [PPC64] Port shenandoahgc to linux on ppc64le Nov 10, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2021

👋 Welcome back nradomski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 10, 2021

@Quaffel The following labels will be automatically applied to this pull request:

  • build
  • hotspot
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org hotspot hotspot-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Nov 10, 2021
@Quaffel Quaffel marked this pull request as ready for review Nov 11, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 11, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2021

Webrevs

Copy link
Contributor

@rkennke rkennke left a comment

Hi Niklas,
thanks for this awesome work!
I can't really comment on the actual PPC code, so this needs to be reviewed by somebody else. Structurally the change looks correct. I have one comment about the C1 CAS barrier code, but it's minor.

Thanks & cheers,
Roman

@openjdk
Copy link

openjdk bot commented Nov 11, 2021

@Quaffel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276927: [PPC64] Port shenandoahgc to linux on ppc64le

Reviewed-by: rkennke, ihse, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

  • 8db0c36: 8277414: ProblemList runtime/CommandLine/VMDeprecatedOptions.java on windows-x64
  • 03473b4: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor
  • ce0f00f: 8276093: Improve naming in closures to iterate over card sets
  • 5d249c4: 8275071: [macos] A11y cursor gets stuck when combobox is closed
  • 354a34e: 8277336: Improve CollectedHeap::safepoint_workers comments
  • 276bfcd: 8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058
  • d93b238: 8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64
  • 00c388b: 8259643: ZGC can return metaspace OOM prematurely
  • a44b45f: 4337793: Mark non-serializable fields of java.security.cert.Certificate and CertPath
  • b3a62b4: 8276795: Deprecate seldom used CDS flags
  • ... and 107 more: https://git.openjdk.java.net/jdk/compare/fd0a25e62b2c8abc3a419c2e80abbcf11c9e882f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rkennke, @magicus, @TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 11, 2021
Copy link
Member

@magicus magicus left a comment

Build changes look good. Actual code changes needs to be reviewed by someone more knowledgable about this area.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Nice work! Looks correct.
For others: Note that this change already contains feedback from my offline review.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Thanks for the update! I think it's good to go.

@Quaffel
Copy link
Member Author

Quaffel commented Nov 18, 2021

Thank you for your reviews! Happy to see that the change has been so well received.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 18, 2021
@openjdk
Copy link

openjdk bot commented Nov 18, 2021

@Quaffel
Your change (at version c504b66) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

TheRealMDoerr commented Nov 18, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 18, 2021

Going to push as commit 57eb864.
Since your change was applied there have been 117 commits pushed to the master branch:

  • 8db0c36: 8277414: ProblemList runtime/CommandLine/VMDeprecatedOptions.java on windows-x64
  • 03473b4: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor
  • ce0f00f: 8276093: Improve naming in closures to iterate over card sets
  • 5d249c4: 8275071: [macos] A11y cursor gets stuck when combobox is closed
  • 354a34e: 8277336: Improve CollectedHeap::safepoint_workers comments
  • 276bfcd: 8277407: javax/swing/plaf/synth/SynthButtonUI/6276188/bug6276188.java fails to compile after JDK-8276058
  • d93b238: 8277180: Intrinsify recursive ObjectMonitor locking for C2 x64 and A64
  • 00c388b: 8259643: ZGC can return metaspace OOM prematurely
  • a44b45f: 4337793: Mark non-serializable fields of java.security.cert.Certificate and CertPath
  • b3a62b4: 8276795: Deprecate seldom used CDS flags
  • ... and 107 more: https://git.openjdk.java.net/jdk/compare/fd0a25e62b2c8abc3a419c2e80abbcf11c9e882f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 18, 2021
@openjdk
Copy link

openjdk bot commented Nov 18, 2021

@TheRealMDoerr @Quaffel Pushed as commit 57eb864.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Quaffel Quaffel deleted the feat/shenandoah-ppc64 branch Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
4 participants