Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277413: Remove unused local variables in jdk.hotspot.agent #6329


Copy link

@turbanoff turbanoff commented Nov 10, 2021


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8277413: Remove unused local variables in jdk.hotspot.agent



Using git

Checkout this PR locally:
$ git fetch pull/6329/head:pull/6329
$ git checkout pull/6329

Update a local copy of the PR:
$ git checkout pull/6329
$ git pull pull/6329/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 6329

View PR using the GUI difftool:
$ git pr show -t 6329

Using diff file

Download this PR as a diff file:

Copy link

@bridgekeeper bridgekeeper bot commented Nov 10, 2021

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link

@openjdk openjdk bot commented Nov 10, 2021

@turbanoff The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability hotspot-gc labels Nov 10, 2021
@turbanoff turbanoff changed the title [PATCH] Remove unused local variables in jdk.hotspot.agent 8277413: Remove unused local variables in jdk.hotspot.agent Nov 18, 2021
@openjdk openjdk bot added the rfr label Nov 18, 2021
Copy link

@mlbridge mlbridge bot commented Nov 18, 2021


Copy link

@openjdk openjdk bot commented Nov 21, 2021

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8277413: Remove unused local variables in jdk.hotspot.agent

Reviewed-by: lmesnik, tschatzl, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 155 new commits pushed to the master branch:

  • e529865: 8277239: SIGSEGV in vrshift_reg_maskedNode::emit
  • 8683de5: 8274685: Documentation suggests there are ArbitrarilyJumpableGenerator when none
  • 6b4fbae: 8273792: JumpableGenerator.rngs() documentation refers to wrong method
  • d427c79: 8277428: G1: Move and inline G1STWIsAliveClosure::do_object_b
  • 32839ba: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"
  • 8051041: 8277534: Remove unused ReferenceProcessor::has_discovered_references
  • 3f847fe: 8277385: Zero: Enable CompactStrings support
  • ca31ed5: 8275448: [REDO] AArch64: Implement string_compare intrinsic in SVE
  • 4ff4301: 8224922: Access JavaFileObject from Element(s)
  • 0a9e76c: 8277485: Zero: Fix fast{i,f}access_0 bytecodes handling
  • ... and 145 more:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik, @tschatzl, @sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 21, 2021
Copy link

@tschatzl tschatzl left a comment


Copy link

@sspitsyn sspitsyn left a comment

Looks good.

Copy link
Member Author

@turbanoff turbanoff commented Nov 22, 2021


@openjdk openjdk bot added the sponsor label Nov 22, 2021
Copy link

@openjdk openjdk bot commented Nov 22, 2021

Your change (at version 2a73593) is now ready to be sponsored by a Committer.

Copy link

@tschatzl tschatzl commented Nov 23, 2021


Copy link

@openjdk openjdk bot commented Nov 23, 2021

Going to push as commit 66eaf65.
Since your change was applied there have been 169 commits pushed to the master branch:

  • 36b887a: 8277560: Remove WorkerDataArray::_is_serial
  • 017df14: 8277556: Call ReferenceProcessorPhaseTimes::set_processing_is_mt once
  • 79350b9: 8276216: Negated character classes performance regression in Pattern
  • e3243ee: 8277087: ZipException: zip END header not found at ZipFile#Source.findEND
  • 12f08ba: 8277507: Add jlink.debug system property while launching jpackage tests to help diagonize recent intermittent failures
  • bb11c55: 8277542: G1: Move G1CardSetFreePool and related classes to separate files
  • f62b81c: 8273095: vmTestbase/vm/mlvm/anonloader/stress/oome/heap/ fails with "wrong OOME"
  • 05a9a51: 8277423: ciReplay: hidden class with comment expected error
  • 1049aba: 8277576: ProblemList runtime/ErrorHandling/ on macosx-X64
  • 851a362: 8264297: Create implementation for NSAccessibilityProgressIndicator protocol peer
  • ... and 159 more:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Nov 23, 2021
Copy link

@openjdk openjdk bot commented Nov 23, 2021

@tschatzl @turbanoff Pushed as commit 66eaf65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the removed_unused_local_variables_jdk.hotspot.agent branch Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
hotspot-gc integrated serviceability
4 participants