JDK-8252870: Finalize (remove "incubator" from) jpackage

[andyherrick]

JDK-8252870: Finalize (remove "incubator" from) jpackage

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	⏳ (1/2 running)
Test (tier1)	⏳ (3/9 running)	⏳ (3/9 running)	⏳ (9/9 running)

Issue

• JDK-8252870: Finalize (remove "incubator" from) jpackage

Reviewers

• Kevin Rushforth (@kevinrushforth - Author) ⚠️ Review applies to 4b1e636
• Erik Joelsson (@erikj79 - Reviewer) ⚠️ Review applies to 4b1e636
• Alexander Matveev (@sashamatveev - Committer) ⚠️ Review applies to 4b1e636
• Alexey Semenyuk (@alexeysemenyukoracle - Committer) ⚠️ Review applies to 4b1e636
• Phil Race (@prrace - Reviewer) ⚠️ Review applies to 4b1e636
• Magnus Ihse Bursie (@magicus - Reviewer) ⚠️ Review applies to 8bf6b0a

Download

$ git fetch https://git.openjdk.java.net/jdk pull/633/head:pull/633
$ git checkout pull/633

[bridgekeeper]

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @andyherrick This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[openjdk]

@andyherrick The following labels will be automatically applied to this pull request:

• build
• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full (e5473b1)
• 04: Full (76f8496)
• 03: Full (8bf6b0a)
• 02: Full (7857012)
• 01: Full - Incremental (4b1e636)
• 00: Full (4b95b41)

[andyherrick]

/csr

[andyherrick]

/reviewer almatvee, asemenyuk, prr, kcr

[openjdk]

@andyherrick this pull request will not be integrated until the CSR request JDK-8253722 for issue JDK-8252870 has been approved.

[openjdk]

@andyherrick Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

• /reviewer credit @openjdk-bot
• /reviewer credit duke
• /reviewer credit @user1 @user2

[andyherrick]

/reviewer credit almatvee asemenyuk prr kcr

[openjdk]

@andyherrick
Reviewer almatvee successfully credited.

Reviewer asemenyuk successfully credited.

Reviewer prr successfully credited.

Reviewer kcr successfully credited.

[kevinrushforth]

I spot checked it and left a couple comments. The rest looks good. I'll review it in more detail later this week.

[kevinrushforth]

I think you need to revert this. Note this comment:

 # ### THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT. ###

[andyherrick]

reverted

[kevinrushforth]

Similarly, I think you need to revert this.

[andyherrick]

reverted

[kevinrushforth]

Change to @since 16

[andyherrick]

changed to @since16

[kevinrushforth]

@andyherrick the "reviewer credit" command should not be used in this manner. It is intended for the case where an offline review of a PR has been done elsewhere and you wish to record that in the commit. It is not how you ask someone to do a review.

[kevinrushforth]

You can't directly, so I usually just mention in a comment who I want to review it. If you use their GitHub username it will notify them (unless they have disabled all notifications). Something like this:

@prrace @kevinrushforth @sashamatveev @alexeysemenyukoracle please review

[andyherrick]

/reviewer remove almatvee asemenyuk prr kcr

[openjdk]

@andyherrick
Reviewer almatvee successfully removed.

Reviewer asemenyuk successfully removed.

Reviewer prr successfully removed.

Reviewer kcr successfully removed.

[erikj79]

Build changes look good.

[sashamatveev]

Not sure why it was changed. Looks like git recorded file renaming incorrectly.

[kevinrushforth]

Yes, sometime GIt / Github get a bit confused about identifying rename/copy when generating a diff for a renamed file with changes. The result is correct, but the diff looks odd.

[sashamatveev]

Looks like another rename issue.

[kevinrushforth]

Yes (or more precisely another issue displaying the diffs for a renamed file with changes).

[sashamatveev]

Another rename issue.

[kevinrushforth]

Looks good. I double-checked all of the file renames and all are exactly as expected. The diffs got a bit confused in a couple cases, where it thought that a renamed and modified file was copied from somewhere else (see inline comments), but that can happen given that git doesn't actually track renames and copies).

[kevinrushforth]

Yes, sometime GIt / Github get a bit confused about identifying rename/copy when generating a diff for a renamed file with changes. The result is correct, but the diff looks odd.

[kevinrushforth]

Yes (or more precisely another issue displaying the diffs for a renamed file with changes).

[andyherrick]

src/jdk.jpackage/macosx/classes/module-info.java.extra
jdk.jpackage.internal.MacAppBundler,
jdk.jpackage.internal.MacAppStoreBundler,

not related to this change directly, but even in 14 there was no MacAppStoreBundler - actually there is, but it should be removed, it's isSupported() method always returns false.

[prrace]

Amazing how many places the word incubator appeared.
I am approving on the understanding that all the automated jpackage tests pass on all platforms.

[openjdk]

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252870: Finalize (remove "incubator" from) jpackage

Reviewed-by: kcr, erikj, almatvee, asemenyuk, prr, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 804bd72: 8255128: linux x86 build failure with libJNIPoint.c
• 160759c: 8255838: Use 32-bit immediate movslq in macro assembler if 64-bit value fits in 32 bits on x86_64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

Build changes look good.

[andyherrick]

/integrate

[openjdk]

@andyherrick Since your change was applied there have been 2 commits pushed to the master branch:

• 804bd72: 8255128: linux x86 build failure with libJNIPoint.c
• 160759c: 8255838: Use 32-bit immediate movslq in macro assembler if 64-bit value fits in 32 bits on x86_64

Your commit was automatically rebased without conflicts.

Pushed as commit 26e7ef7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.